Attachment 314042 Details for Bug 458756 – Upstream patch for this issue

[patch] Upstream patch for this issue

0001-dlm-check-for-null-in-device_write.patch (text/plain), 1.03 KB, created by Eugene Teo (Security Response) on 2008-08-12 04:13:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eugene Teo (Security Response)

Created: 2008-08-12 04:13:55 UTC

Size: 1.03 KB

patch

obsolete

>From 254ae43ab8d7877c980fca3636624e0777a70fa4 Mon Sep 17 00:00:00 2001
>From: Masatake YAMATO <yamato@redhat.com>
>Date: Wed, 28 May 2008 14:45:10 +0900
>Subject: [PATCH] dlm: check for null in device_write
>
>If `device_write' method is called via "dlm-control",
>file->private_data is NULL. (See ctl_device_open() in
>user.c. ) Through proc->flags is read.
>
>Signed-off-by: Masatake YAMATO <yamato@redhat.com>
>Signed-off-by: David Teigland <teigland@redhat.com>
>---
> fs/dlm/user.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/fs/dlm/user.c b/fs/dlm/user.c
>index ebbcf38..1aa76b3 100644
>--- a/fs/dlm/user.c
>+++ b/fs/dlm/user.c
>@@ -538,7 +538,7 @@ static ssize_t device_write(struct file *file, const char __user *buf,
> 
> 	/* do we really need this? can a write happen after a close? */
> 	if ((kbuf->cmd == DLM_USER_LOCK || kbuf->cmd == DLM_USER_UNLOCK) &&
>-	    test_bit(DLM_PROC_FLAGS_CLOSING, &proc->flags))
>+	    (proc && test_bit(DLM_PROC_FLAGS_CLOSING, &proc->flags)))
> 		return -EINVAL;
> 
> 	sigfillset(&allsigs);
>-- 
>1.5.5.1
>

Actions: View | Diff

Attachments on bug 458756: 314042