Attachment 314067 Details for Bug 458774 – Patch from Denis V.Lunev

[patch] Patch from Denis V.Lunev

nfs-bug_on-in-nfs_follow_mountpoint.patch (text/plain), 1.06 KB, created by Vasily Averin on 2008-08-12 08:07:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vasily Averin

Created: 2008-08-12 08:07:49 UTC

Size: 1.06 KB

patch

obsolete

>Subject: nfs: BUG_ON in nfs_follow_mountpoint
>From: "Denis V. Lunev" <den@openvz.org>
>
>Unfortunately, BUG_ON(IS_ROOT(dentry)) can happen inside
>nfs_follow_mountpoint with NFS running Fedora 8 using a specific setup.
>
>See https://bugzilla.redhat.com/show_bug.cgi?id=458622
>
>So the situation should be handled on NFS client gracefully.
>
>Signed-off-by: Denis V. Lunev <den@openvz.org>
>Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
>Cc: J. Bruce Fields <bfields@fieldses.org>
>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>---
>
> fs/nfs/namespace.c |    5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff -puN fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint fs/nfs/namespace.c
>--- a/fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint
>+++ a/fs/nfs/namespace.c
>@@ -105,7 +105,10 @@ static void * nfs_follow_mountpoint(stru
> 
> 	dprintk("--> nfs_follow_mountpoint()\n");
> 
>-	BUG_ON(IS_ROOT(dentry));
>+	err = -ESTALE;
>+	if (IS_ROOT(dentry))
>+		goto out_err;
>+
> 	dprintk("%s: enter\n", __func__);
> 	dput(nd->path.dentry);
> 	nd->path.dentry = dget(dentry);
>_

Actions: View | Diff

Attachments on bug 458774: 314065 | 314066 | 314067