Attachment 314231 Details for Bug 459006 – Patch to add isnull and isnotnull to boolean charts (v1)

[patch] Patch to add isnull and isnotnull to boolean charts (v1)

isnotnull.patch (text/plain), 2.28 KB, created by David Lawrence on 2008-08-13 18:35:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-08-13 18:35:41 UTC

Size: 2.28 KB

patch

obsolete

>Index: template/en/default/search/boolean-charts.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/template/en/default/search/boolean-charts.html.tmpl,v
>retrieving revision 1.3
>diff -u -r1.3 boolean-charts.html.tmpl
>--- template/en/default/search/boolean-charts.html.tmpl	25 May 2008 04:23:44 -0000	1.3
>+++ template/en/default/search/boolean-charts.html.tmpl	13 Aug 2008 18:33:48 -0000
>@@ -41,7 +41,9 @@
>   { name => "changedfrom", description => "changed from" },
>   { name => "changedto", description => "changed to" },
>   { name => "changedby", description => "changed by" },
>-  { name => "matches", description => "matches" } ] %]
>+  { name => "matches", description => "matches" },
>+  { name => "isnull", description => "Is Null" },
>+  { name => "isnotnull", description => "Is Not Null" }] %]
> 
>   <p>
>     <strong>
>Index: Bugzilla/Search.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/Search.pm,v
>retrieving revision 1.29
>diff -u -r1.29 Search.pm
>--- Bugzilla/Search.pm	11 Aug 2008 21:30:27 -0000	1.29
>+++ Bugzilla/Search.pm	13 Aug 2008 18:33:50 -0000
>@@ -512,6 +512,8 @@
>         ",(changedbefore|changedafter)" => \&_changedbefore_changedafter,
>         ",(changedfrom|changedto)" => \&_changedfrom_changedto,
>         ",changedby" => \&_changedby,
>+        ",isnull" => \&_isnull,
>+        ",isnotnull" => \&_isnotnull,
>     );
> 
>     # REDHAT EXTENSION START 406161
>@@ -667,7 +669,7 @@
>                 $v = $params->param("value$chart-$row-$col");
>                 $v = "" if !defined $v;
>                 $v = trim($v);
>-                if ($f eq "noop" || $t eq "noop" || $v eq "") {
>+                if ($f eq "noop" || $t eq "noop" || ($v eq "" && $t ne "isnull" && $t ne "isnotnull")) {
>                     next;
>                 }
>                 # chart -1 is generated by other code above, not from the user-
>@@ -2248,4 +2250,18 @@
>     $$term = "($table.bug_when IS NOT NULL)";
> }
> 
>+sub _isnull {
>+    my $self = shift;
>+    my %func_args = @_;
>+    my ($ff, $term) = @func_args{qw(ff term)};
>+    $$term = "$$ff IS NULL";
>+}
>+
>+sub _isnotnull {
>+    my $self = shift;
>+    my %func_args = @_;
>+    my ($ff, $term) = @func_args{qw(ff term)};
>+    $$term = "$$ff IS NOT NULL"; 
>+}
>+
> 1;

Flags:

nelhawar: review+

Actions: View | Diff

Attachments on bug 459006: 314231