Attachment 314236 Details for Bug 457770 – Patch to add system.multicall functionality to compat_xmlrpc layer (v1)

[patch] Patch to add system.multicall functionality to compat_xmlrpc layer (v1)

system_multicall.patch (text/plain), 2.27 KB, created by David Lawrence on 2008-08-13 19:09:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-08-13 19:09:47 UTC

Size: 2.27 KB

patch

obsolete

>Index: extensions/compat_xmlrpc/code/webservice.pl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/extensions/compat_xmlrpc/code/webservice.pl,v
>retrieving revision 1.48
>diff -u -r1.48 webservice.pl
>--- extensions/compat_xmlrpc/code/webservice.pl	8 Aug 2008 20:41:38 -0000	1.48
>+++ extensions/compat_xmlrpc/code/webservice.pl	13 Aug 2008 19:06:52 -0000
>@@ -24,7 +24,70 @@
> use warnings;
> use Bugzilla;
> my $dispatch = Bugzilla->hook_args->{dispatch};
>-$dispatch->{bugzilla} = "bugzilla";
>+$dispatch->{'bugzilla'} = "bugzilla";
>+$dispatch->{'system'}   = "system";
>+
>+package system;
>+
>+## libraries and pragmas
>+use base qw(Bugzilla::WebService);
>+import SOAP::Data qw(type);
>+use Bugzilla;
>+use Bugzilla::Constants;
>+use Bugzilla::WebService::Constants;
>+
>+# Basic info that is needed before logins
>+use constant LOGIN_EXEMPT => {
>+    ping => 1,
>+};
>+
>+my $logger = Bugzilla->logger;
>+
>+sub multicall {
>+    my ($self, $calls) = @_;
>+    my @results;
>+    my %errors;
>+
>+    $logger->debug("Starting");
>+
>+    return if ref($calls) !~ /ARRAY/;
>+
>+    foreach my $call ( @{$calls} ) {
>+        next if ref($call) !~ /HASH/;
>+
>+        my ( $package, $method ) = split( '\.', $call->{'methodName'}, 2 );
>+        next if !$package || !$method;
>+        my $full_method = "$package\:\:$method";
>+        my @params = @{ $call->{'params'} };
>+
>+        $logger->debug("Begin process method: $method");
>+
>+        eval {
>+            no strict 'refs';
>+            push( @results, &$full_method($self, @params) );
>+        };
>+        if (my $e = $@) {
>+            $logger->error("$method: $e");
>+            push( @results,
>+                "Error: $e\n"
>+                . "package => $package, method => $method, full_method => $full_method,  params => ["
>+                . join( ",", @params )
>+                . "]" );
>+        }
>+        # Undefine user data for each call so a relogin must happen
>+        $logger->debug("logout user to force relogin");
>+        Bugzilla->logout_request();
>+        
>+        $logger->debug("End process method: $method");
>+    }
>+
>+    return \@results;
>+}
>+
>+sub ping {
>+    my ($self) = @_;
>+    return 1;
>+}
> 
> package bugzilla;
> 
>@@ -3207,4 +3270,3 @@
> =head1 SEE ALSO
> 
> L<Bugzilla|Bugzilla> L<Bugzilla::RPC|Bugzilla::RPC>
>-

Flags:

nelhawar: review+

Actions: View | Diff

Attachments on bug 457770: 313365 | 314236