Attachment 314381 Details for Bug 214342 – Patch Fix:

[patch] Patch Fix:

bios.patch (text/plain), 3.72 KB, created by XINSUN on 2008-08-15 08:45:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-08-15 08:45:12 UTC

Size: 3.72 KB

patch

obsolete

>Index: hwcert.pl
>===================================================================
>RCS file: /cvs/qa/hwcert/hwcert.pl,v
>retrieving revision 1.57
>diff -u -r1.57 hwcert.pl
>--- hwcert.pl	30 Jul 2008 17:50:59 -0000	1.57
>+++ hwcert.pl	15 Aug 2008 08:38:51 -0000
>@@ -319,11 +319,12 @@
>     my $status     = "";
>     my $resolution = "";
> 
>-    my $supported   = $cgi->param('cert_supported');
>-    my $type        = $cgi->param('cert_type');
>-    my $reason      = $cgi->param('exception_reason');
>-    my $make_public = $cgi->param('make_public');
>-    my $tam_ack     = $cgi->param('tam_ack');
>+    my $supported    = $cgi->param('cert_supported');
>+    my $type         = $cgi->param('cert_type');
>+    my $reason       = $cgi->param('exception_reason');
>+    my $make_public  = $cgi->param('make_public');
>+    my $tam_ack      = $cgi->param('tam_ack');
>+    my $bios_setting = $cgi->param('bios_setting');
> 
>     # Quick hack to avoid certing "UnknownMake"s.
>     my $status_whiteboard = $cgi->param('status_whiteboard');
>@@ -334,6 +335,7 @@
>     trick_taint($supported) if $supported;
>     trick_taint($type) if $type;
>     trick_taint($reason) if $reason;
>+    trick_taint($bios_setting) if $bios_setting;
> 
>     my $bug = new Bugzilla::Bug($id, $userid);
>     ThrowCodeError("bug_error", { bug => $bug }) if $bug->error;
>@@ -478,7 +480,16 @@
>         $sth->execute();
>         $cert_changed = 1;
>     }
>-
>+    
>+    #Log bios setting for special cert.
>+    if ($bios_setting && $bios_setting ne $bug->{'bios_setting'}) {
>+        $query = "UPDATE cert_records SET bios_setting = " . $dbh2->quote($bios_setting) . " WHERE bug_id = $id"; 
>+        Log($query);
>+        $sth = $dbh2->prepare($query);
>+        $sth->execute();
>+        $cert_changed = 1;
>+    }
>+ 
>     if ($certified) {
>         # Add private comment to bug report with details
>         my $submitter = DBID_to_name($userid);
>@@ -536,12 +547,12 @@
> 
>     my $dbh = Bugzilla->dbh2;
>     my $query = "SELECT id, upper(status), upper(cert_type), supported, exception_reason, " .
>-                "hw_sent, hw_ship_info, hw_large_agree, hw_access_info, hw_large_agree_allow " . 
>+                "hw_sent, hw_ship_info, hw_large_agree, hw_access_info, hw_large_agree_allow, bios_setting " . 
>                 "FROM cert_records WHERE bug_id = $bug_id";
>     my $sth = $dbh->prepare($query);
>     $sth->execute();
>     my ($id, $status, $type, $supported, $exception_reason, 
>-        $shipped_to_rh, $shipping_info, $large_agree, $access_info, $agree_allow) = $sth->fetchrow_array();
>+        $shipped_to_rh, $shipping_info, $large_agree, $access_info, $agree_allow,$bios_setting) = $sth->fetchrow_array();
> 
>     my %cert_info;    
>     $cert_info{'id'}               = $id;
>@@ -559,6 +570,7 @@
>     $cert_info{'large_agree'}       = $large_agree;
>     $cert_info{'access_info'}       = $access_info;
>     $cert_info{'large_agree_allow'} = $agree_allow;
>+    $cert_info{'bios_setting'}      = $bios_setting;
> 
>     return \%cert_info;
> }
>Index: template/en/default/bug/rh_edit.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/bug/rh_edit.html.tmpl,v
>retrieving revision 1.19
>diff -u -r1.19 rh_edit.html.tmpl
>--- template/en/default/bug/rh_edit.html.tmpl	29 Jul 2008 18:43:01 -0000	1.19
>+++ template/en/default/bug/rh_edit.html.tmpl	15 Aug 2008 08:38:51 -0000
>@@ -63,7 +63,10 @@
>         <td>
>         <input type="text" name="exception_reason" value="[% bug.exception_reason FILTER html %]" size="40" maxsize="200">
>         </td>
>-      </tr>
>+      </tr><tr>
>+         <th>Special BIOS/Firmware Setting</th>
>+         <td>
>+         <input type="text" name="bios_setting" value="[% bug.bios_setting FILTER html %]" size="40" maxsize="200">
>       </table>
>       </p>
>

Actions: View | Diff

Attachments on bug 214342: 314381