Attachment 314389 Details for Bug 224305 – Patch Fix.

[patch] Patch Fix.

msg.patch (text/plain), 3.17 KB, created by XINSUN on 2008-08-15 13:52:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-08-15 13:52:12 UTC

Size: 3.17 KB

patch

obsolete

>Index: template/en/default/global/user-error.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/global/user-error.html.tmpl,v
>retrieving revision 1.20
>diff -u -r1.20 user-error.html.tmpl
>--- template/en/default/global/user-error.html.tmpl	31 Jul 2008 20:10:36 -0000	1.20
>+++ template/en/default/global/user-error.html.tmpl	15 Aug 2008 13:47:52 -0000
>@@ -452,21 +452,17 @@
>     [% title = "Access Denied" %]
>     Only member of hwcert_edit group can do "[% action FILTER html %]".
>   
>-  [% ELSIF error == "hwcert_edit_denied" %]
>-    [% title = "Access Denied" %]
>-    Testplan status is currently frozen, you are not allowed to modify.
>-  
>   [% ELSIF error == "Testplan_freeze_error" %]
>-    [% title = "Testplan status error" %]
>-    Testplan status is currently frozen, you are not allowed to add a new item or change removed flag...
>+    [% title = "Testplan freeze error" %]
>+    Permission denied, testplan frozen.
>  
>   [% ELSIF error == "Testplan_leverage_format_error" %]
>     [% title = "Testplan leverage format error" %]
>-    Make sure Leverage Bug Id is numeric.
>+    Make sure Leverage Id is numeric.
> 
>   [% ELSIF error == "Test_does_not_exist" %]
>     [% title = "Test ID not Found" %]
>-    Test ID [% test_id FILTER html %] was not found, please press back and select a valid Test ID.
>+    Test ID [% test_id FILTER html %] was not found, please press back and enter a valid Test ID.
> 
>   [% ELSIF error == "Test_ID_is_in_this_certification" %]
>     [% title = "Test ID is local" %]
>@@ -476,10 +472,6 @@
>     [% title = "Create conflict error" %]
>     You can not specify Make and Model while there is a result rpm.
> 
>-  [% ELSIF error == "Parse failure" %]
>-    [% title = "Parse failure" %]
>-    Test plan line greater than 150 characters.
>-
>   [% ELSIF error == "keyword_already_exists" %]
>     [% title = "Keyword Already Exists" %]
>     A keyword with the name [% name FILTER html %] already exists.
>Index: process.cgi
>===================================================================
>RCS file: /cvs/qa/hwcert/process.cgi,v
>retrieving revision 1.36
>diff -u -r1.36 process.cgi
>--- process.cgi	31 Jul 2008 20:10:35 -0000	1.36
>+++ process.cgi	15 Aug 2008 13:47:57 -0000
>@@ -2229,13 +2229,6 @@
>             trick_taint($area);
>             $area =~ s/\r//g;
>             $area = trim($area);
>-            my $eachline;
>-            foreach $eachline( split(/\n/,$area) ) {
>-                trick_taint($eachline);
>-                if ( length($eachline) > 150 ) {
>-                    ThrowUserError("Parse failure");
>-                }
>-            }
>         }
>         trick_taint($flag);
> 
>Index: hwcert.pl
>===================================================================
>RCS file: /cvs/qa/hwcert/hwcert.pl,v
>retrieving revision 1.57
>diff -u -r1.57 hwcert.pl
>--- hwcert.pl	30 Jul 2008 17:50:59 -0000	1.57
>+++ hwcert.pl	15 Aug 2008 13:47:59 -0000
>@@ -1496,9 +1508,6 @@
> 
>         if ( $eachline =~ m/--=ADDITIONAL TEST PLAN LINES=--/ || 
> 	   $eachline =~ m/^\s+$/ ) { next };
>-        if ( length($eachline) > 150 ) {
>-                ThrowUserError("Parse failure");
>-        }
> 
>         my $testplan_class;
>         my $testplan_description;

Actions: View | Diff

Attachments on bug 224305: 313905 | 314389 | 314522