Attachment 314733 Details for Bug 459729 – fix some memory leaks

[patch] fix some memory leaks

0005-fix-some-memory-leaks.patch (text/plain), 1.64 KB, created by Rich Megginson on 2008-08-21 17:17:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rich Megginson

Created: 2008-08-21 17:17:47 UTC

Size: 1.64 KB

patch

obsolete

>From f0e09d7ea3dac3f7fba6b0a9df72bb0e621480e5 Mon Sep 17 00:00:00 2001
>From: Rich Megginson <rmeggins@redhat.com>
>Date: Wed, 20 Aug 2008 14:06:34 -0600
>Subject: [PATCH] fix some memory leaks
>
>---
> .../ipa-winsync/ipa-winsync-config.c               |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/ipa-server/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c b/ipa-server/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c
>index dc13e6e..1cf2c7a 100644
>--- a/ipa-server/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c
>+++ b/ipa-server/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c
>@@ -506,6 +506,7 @@ ipa_winsync_config_destroy_domain(
>     slapi_entry_free(iwdc->domain_e);
>     iwdc->domain_e = NULL;
>     slapi_ch_free_string(&iwdc->realm_name);
>+    slapi_ch_free_string(&iwdc->homedir_prefix);
>     slapi_ch_free((void **)&iwdc);
> 
>     return;
>@@ -749,7 +750,8 @@ ipa_winsync_config_refresh_domain(
>     slapi_entry_add_valueset(iwdc->domain_e, "objectclass", new_user_objclasses);
> 
>     /* set the default gid number */
>-    sv = slapi_value_new_string(default_gid);
>+    sv = slapi_value_new_string_passin(default_gid);
>+    default_gid = NULL; /* passin owns the memory */
>     if (!slapi_entry_attr_has_syntax_value(iwdc->domain_e, "gidNumber", sv)) {
>         slapi_entry_add_value(iwdc->domain_e,  "gidNumber", sv);
>     }
>@@ -767,6 +769,7 @@ out:
>     slapi_ch_free_string(&default_group_filter);
>     slapi_ch_free_string(&default_group_name);
>     slapi_ch_free_string(&real_group_filter);
>+    slapi_ch_free_string(&default_gid);
> 
>     if (LDAP_SUCCESS != ret) {
>         slapi_ch_free_string(&iwdc->realm_name);
>-- 
>1.5.5.1
>

Actions: View | Diff

Attachments on bug 459729: 314729 | 314730 | 314731 | 314732 | 314733 | 314844 | 314845 | 316460 | 317002 | 317807 | 318214 | 319412 | 319413 | 319414 | 319415 | 319416 | 319786 | 320039 | 320040