Attachment 314829 Details for Bug 438761 – Move bus notification nearlier in device_add

Move bus notification nearlier in device_add

new_fix1 (text/plain), 1.25 KB, created by IBM Bug Proxy on 2008-08-22 18:42:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2008-08-22 18:42:10 UTC

Size: 1.25 KB

patch

obsolete

>Bus notification was placed in a wrong place. Move it before the udev notifications.
>
>Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
>---
>
>Index: linux-2.6.18.ppc64/drivers/base/core.c
>===================================================================
>--- linux-2.6.18.ppc64.orig/drivers/base/core.c
>+++ linux-2.6.18.ppc64/drivers/base/core.c
>@@ -309,6 +309,16 @@ int device_add(struct device *dev)
> 	if ((error = kobject_add(&dev->kobj)))
> 		goto Error;
> 
>+	/* notify clients of device entry (new way) */
>+	if (dev->bus) {
>+		struct blocking_notifier_head *notifier_head;
>+
>+		notifier_head = get_notifier_for_bus(dev->bus);
>+		if (notifier_head)
>+			blocking_notifier_call_chain(notifier_head,
>+						BUS_NOTIFY_ADD_DEVICE, dev);
>+	}
>+
> 	dev->uevent_attr.attr.name = "uevent";
> 	dev->uevent_attr.attr.mode = S_IWUSR;
> 	if (dev->driver)
>@@ -369,15 +379,6 @@ int device_add(struct device *dev)
> 	if (platform_notify)
> 		platform_notify(dev);
> 
>-	/* notify clients of device entry (new way) */
>-	if (dev->bus) {
>-		struct blocking_notifier_head *notifier_head;
>-
>-		notifier_head = get_notifier_for_bus(dev->bus);
>-		if (notifier_head)
>-			blocking_notifier_call_chain(notifier_head,
>-						BUS_NOTIFY_ADD_DEVICE, dev);
>-	}
>  Done:
>  	kfree(class_name);
> 	put_device(dev);

Actions: View

Attachments on bug 438761: 314153 | 314154 | 314155 | 314156 | 314157 | 314158 | 314159 | 314160 | 314161 | 314162 | 314163 | 314339 | 314426 | 314828 | 314829 | 316641