Attachment 314984 Details for Bug 457835 – The dump utility may set the expiration date to 0 which is a special value to be ignored or the account will stop working

[patch] The dump utility may set the expiration date to 0 which is a special value to be ignored or the account will stop working

freeipa-fix-expire.patch (text/plain), 1.59 KB, created by Simo Sorce on 2008-08-26 12:49:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simo Sorce

Created: 2008-08-26 12:49:57 UTC

Size: 1.59 KB

patch

obsolete

>From cb641d756f0b3e55cc795cacbf122d7b0a6b1c77 Mon Sep 17 00:00:00 2001
>From: Simo Sorce <ssorce@redhat.com>
>Date: Wed, 6 Aug 2008 17:22:51 -0400
>Subject: [PATCH] Treat Jan 1 1970 in krbPrincipalExpiration as a special date that means the account Never Expires
>
>---
> .../ipa-pwd-extop/ipa_pwd_extop.c                  |    8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>index be440e8..56003f2 100644
>--- a/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>+++ b/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>@@ -1240,10 +1240,11 @@ static int ipapwd_CheckPolicy(struct ipapwd_data *data)
> 	int tmp, ret;
> 	const char *old_pw;
> 
>-	/* check account is not expired */
>+	/* check account is not expired. Ignore unixtime = 0 (Jan 1 1970) */
> 	krbPrincipalExpiration = slapi_entry_attr_get_charptr(data->target, "krbPrincipalExpiration");
>-	if (krbPrincipalExpiration) {
>-		/* if expiration date set check it */
>+	if (krbPrincipalExpiration &&
>+	    (strcasecmp("19700101000000Z", krbPrincipalExpiration) != 0)) {
>+		/* if expiration date is set check it */
> 		memset(&tm, 0, sizeof(struct tm));
> 		ret = sscanf(krbPrincipalExpiration,
> 			     "%04u%02u%02u%02u%02u%02u",
>@@ -1261,6 +1262,7 @@ static int ipapwd_CheckPolicy(struct ipapwd_data *data)
> 		}
> 		/* FIXME: else error out ? */
> 	}
>+	slapi_ch_free_string(&krbPrincipalExpiration);
> 
> 	/* find the entry with the password policy */
> 	ret = ipapwd_getPolicy(data->dn, data->target, &policy);
>-- 
>1.5.5.1
>

Actions: View | Diff

Attachments on bug 457835: 314983 | 314984 | 314985 | 314986 | 314987 | 314988 | 314989