Attachment 315128 Details for Bug 460351 – Patch to add cf_pm_score as a new Red Hat field (v1)

[patch] Patch to add cf_pm_score as a new Red Hat field (v1)

cf_pm_score.patch (text/plain), 3.28 KB, created by David Lawrence on 2008-08-27 18:12:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-08-27 18:12:05 UTC

Size: 3.28 KB

patch

obsolete

>? bugzilla-3.2rh-20080827.1.tar.gz
>? bugzilla.spec
>? localconfig
>? patches
>? data/params
>Index: extensions/compat_xmlrpc/code/webservice.pl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/extensions/compat_xmlrpc/code/webservice.pl,v
>retrieving revision 1.52
>diff -u -r1.52 webservice.pl
>--- extensions/compat_xmlrpc/code/webservice.pl	26 Aug 2008 16:18:02 -0000	1.52
>+++ extensions/compat_xmlrpc/code/webservice.pl	27 Aug 2008 18:09:43 -0000
>@@ -254,6 +254,10 @@
>     if (Bugzilla->user->in_group('devel')) {
>         $item{devel_whiteboard} = type('string')->value($bug->cf_devel_whiteboard);
>     }
>+    
>+    if (Bugzilla->user->in_group('product_management')) {
>+        $item{pm_score} = type('string')->value($bug->cf_pm_score);
>+    }
> 
>     $item{groups} = $bug->groups_in;
> 
>@@ -380,6 +384,7 @@
>         'internal_whiteboard' => 'cf_internal_whiteboard',
>         'issuetracker'        => 'cf_issuetracker',
>         'release_notes'       => 'cf_release_notes',
>+        'pm_score'            => 'cf_pm_score',
>     );
> 
>     foreach my $key ( keys %custom_field_return_map ) {
>@@ -514,6 +519,7 @@
>         'qa_whiteboard'       => 'cf_qa_whiteboard',
>         'internal_whiteboard' => 'cf_internal_whiteboard',
>         'issuetrackers'       => 'cf_issuetracker',
>+        'pm_score'            => 'cf_pm_score',
>     );
> 
>     # Group Validation
>@@ -1035,6 +1041,7 @@
>         'qa_whiteboard'       => 'cf_qa_whiteboard',
>         'internal_whiteboard' => 'cf_internal_whiteboard',
>         'issuetracker'        => 'cf_issuetracker',
>+        'pm_score'            => 'cf_pm_score',
>     );
> 
>     # Try to login if $username and $password provided.
>@@ -2191,6 +2198,9 @@
>     if ( not Bugzilla->user->in_group('issuetracker') ) {
>         delete $ok_field{'issuetrackers'};
>     }
>+    if ( not Bugzilla->user->in_group('product_management') ) {
>+        delete $ok_field{'pm_score'};
>+    }
> 
>     return [ keys %ok_field ];
> }
>Index: extensions/redhat_fields/code/filter_change.pl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/extensions/redhat_fields/code/filter_change.pl,v
>retrieving revision 1.2
>diff -u -r1.2 filter_change.pl
>--- extensions/redhat_fields/code/filter_change.pl	7 Mar 2008 21:45:07 -0000	1.2
>+++ extensions/redhat_fields/code/filter_change.pl	27 Aug 2008 18:09:43 -0000
>@@ -30,6 +30,7 @@
>     cf_qa_whiteboard       => 'qa',
>     cf_internal_whiteboard => 'internalwhiteboard',
>     cf_cust_facing         => 'rhn',
>+    cf_pm_score            => 'product_management',
> );
> 
> if ( exists $permission_map{$field} 
>Index: extensions/redhat_fields/code/filter_custom_fields.pl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/extensions/redhat_fields/code/filter_custom_fields.pl,v
>retrieving revision 1.1
>diff -u -r1.1 filter_custom_fields.pl
>--- extensions/redhat_fields/code/filter_custom_fields.pl	5 Mar 2008 21:41:51 -0000	1.1
>+++ extensions/redhat_fields/code/filter_custom_fields.pl	27 Aug 2008 18:09:43 -0000
>@@ -31,6 +31,7 @@
>     cf_qa_whiteboard       => 'qa',
>     cf_internal_whiteboard => 'internalwhiteboard',
>     cf_cust_facing         => 'rhn',
>+    cf_pm_score            => 'product_management',
> );
> 
> foreach my $field ( @{$$custom_fields} ) {

Flags:

dkl: review? (nelhawar)

Actions: View | Diff

Attachments on bug 460351: 315128 | 315129