Attachment 315149 Details for Bug 458675 – cvs commit log - HEAD

cvs commit log - HEAD

cvsmsg.bug458675 (text/plain), 1.65 KB, created by Rich Megginson on 2008-08-27 21:09:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rich Megginson

Created: 2008-08-27 21:09:54 UTC

Size: 1.65 KB

patch

obsolete

>Resolves: bug 458675
>Bug Description: Memory leaks in valueset code
>Reviewed by: nkinder,nhosoi (Thanks!)
>Branch: HEAD
>Fix Description: The first leak occurs when you are using replication and you add values to an
>attribute that were previously deleted - that is, the values that you want to
>add are on the attribute's deleted values list and are being "resurrected".
>This leak is caused by an improper bit test (foo & bar|baz).  The or | has
>higher precedence and is evaluated first.  The fix is to use parentheses (foo &
>(bar|baz)).  Note that this issue was flagged by the compiler gcc with -Wall.
>The second leak is caused when several values are being added to an attribute,
>and the list contains non-sequential duplicate values (e.g. foo, bar, baz,
>foo).  The code uses an array of Slapi_Value* called keyvals.  When a valid
>value is found, the Slapi_Value* is moved from keyvals to valuetreep and the
>keyvals array index is set to NULL.  This array is passed to valuearray_free to
>free the individual Slapi_Value* and the array itself.  This works fine in the
>non-error case because there are no Slapi_Value* elements to free, so it just
>frees the array.  However, in the duplicate value case, some of the elements
>have already been set to NULL, so those are skipped over by valuearray_free.
>The fix is to introduce a new function valuearray_free_ext that takes an
>additional argument which is the array index to start freeing from.  That way
>the non-NULL Slapi_Value* elements can be freed along with the array itself.
>Platforms tested: RHEL5, Fedora 8
>Flag Day: no
>Doc impact: no
>QA impact: should be covered by regular nightly and manual testing
>New Tests integrated into TET: none

Actions: View

Attachments on bug 458675: 313970 | 314149 | 315149