Attachment 315197 Details for Bug 460464 – nvr split using rsplit

[patch] nvr split using rsplit

rhnChannel.py.patch2 (text/plain), 2.87 KB, created by Daniel Mach on 2008-08-28 11:06:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Mach

Created: 2008-08-28 11:06:25 UTC

Size: 2.87 KB

patch

obsolete

>--- rhnChannel.py.orig	2008-08-28 12:48:25.000000000 +0200
>+++ rhnChannel.py.new2	2008-08-28 12:56:00.000000000 +0200
>@@ -2281,54 +2281,25 @@
> 
> # IN: 'e:name-version-release' or 'name-version-release:e'
> # OUT: {'name':name, 'version':version, 'release':release, 'epoch':epoch }
>-def make_evr(nvre, source=0):
>-    epoch = ''
>-    name = ''
>-    version = ''
>-    release = ''
>-    list = None
>-    ret = None
>-                                                                                                                                                                                    
>-    #There is an epoch. A ':' is only included when an epoch is present
>-    if string.find(nvre, ':') != -1:
>-        holder = string.split(nvre, ':')
>-                                                                                                                                                                                    
>-        #holder[0] has the n,v,r,a
>-        if string.find(holder[0], '-') != -1:
>-            holder[0] = string.split(holder[0], '-')
>-            ret = {
>-                'name'      :   holder[0][0],
>-                'version'   :   holder[0][1],
>-                'release'   :   holder[0][2],
>-                'epoch'     :   holder[1]
>-            }
>-        elif string.find(holder[1], '-') != -1:
>-            holder[1] = string.split(holder[1], '-')
>-            ret = {
>-                'name'      :   holder[1][0],
>-                'version'   :   holder[1][1],
>-                'release'   :   holder[1][2],
>-                'epoch'     :   holder[0]
>-            }
>-        else:
>-            raise rhnFault(err_code = 21,
>-                err_text = "NVRE is missing name, version, or release.")
>-    elif string.find(nvre, '-') != -1:
>-        nvre = string.split(nvre, '-')
>-        ret = {
>-            'name'      :   nvre[0],
>-            'version'   :   nvre[1],
>-            'release'   :   nvre[2],
>-            'epoch'     :   None
>-        }
>+def make_evr(nvre, source=False):
>+    if ":" in nvre:
>+        nvr, epoch = nvre.rsplit(":", 1)
>+        if "-" in epoch:
>+            nvr, epoch = epoch, nvr
>     else:
>-        return MakeEvrError(message = "NVRE is missing name, version, or release.")
>-    if source:
>-        for key in ret.keys():
>-            if ret[key]:
>-            	if string.find(ret[key], '.src') != -1:
>-                    ret[key] = string.replace(ret[key], '.src', "")
>-    return ret
>+        nvr, epoch = nvre, ""
>+
>+    nvr_parts = nvr.rsplit("-", 2)
>+    if len(nvr_parts) != 3:
>+        raise rhnFault(err_code = 21, err_text = "NVRE is missing name, version, or release.")
>+
>+    result = dict(zip(["name", "version", "release"], nvr_parts))
>+    result["epoch"] = epoch
>+
>+    if source and result["release"].endswith(".src"):
>+        result["release"] = result["release"][:-4]
>+
>+    return result
> 
> def subscribe_to_tools_channel(server_id):
>     """

Actions: View | Diff

Attachments on bug 460464: 315196 | 315197 | 319775