Attachment 315645 Details for Bug 461014 – Patch fixing spin lock

[patch] Patch fixing spin lock

bnx2-poll-fix-badness-1.patch (text/plain), 1.23 KB, created by Flavio Leitner on 2008-09-03 14:27:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Flavio Leitner

Created: 2008-09-03 14:27:44 UTC

Size: 1.23 KB

patch

obsolete

>
>During the netdump the local interrupts are disabled and so
>it shouldn't call spin_unlock_bh() because it can cause a 
>preemption then a warning message is printed and netdump hangs.
>
>Signed-off-by: Flavio Leitner <fleitner@redhat.com>
>
>Index: linux-2.6.9/drivers/net/bnx2.c
>===================================================================
>--- linux-2.6.9.orig/drivers/net/bnx2.c
>+++ linux-2.6.9/drivers/net/bnx2.c
>@@ -248,22 +248,25 @@ static inline u32 bnx2_tx_avail(struct b
> static u32
> bnx2_reg_rd_ind(struct bnx2 *bp, u32 offset)
> {
>+	unsigned long flags;
> 	u32 val;
> 
>-	spin_lock_bh(&bp->indirect_lock);
>+	spin_lock_irqsave(&bp->indirect_lock, flags);
> 	REG_WR(bp, BNX2_PCICFG_REG_WINDOW_ADDRESS, offset);
> 	val = REG_RD(bp, BNX2_PCICFG_REG_WINDOW);
>-	spin_unlock_bh(&bp->indirect_lock);
>+	spin_unlock_irqrestore(&bp->indirect_lock, flags);
> 	return val;
> }
> 
> static void
> bnx2_reg_wr_ind(struct bnx2 *bp, u32 offset, u32 val)
> {
>-	spin_lock_bh(&bp->indirect_lock);
>+	unsigned long flags;
>+
>+	spin_lock_irqsave(&bp->indirect_lock, flags);
> 	REG_WR(bp, BNX2_PCICFG_REG_WINDOW_ADDRESS, offset);
> 	REG_WR(bp, BNX2_PCICFG_REG_WINDOW, val);
>-	spin_unlock_bh(&bp->indirect_lock);
>+	spin_unlock_irqrestore(&bp->indirect_lock, flags);
> }
> 
> static void

Actions: View | Diff

Attachments on bug 461014: 315645 | 319285 | 319290 | 319294 | 319400 | 319686