Attachment 316078 Details for Bug 461477 – OpenBSD patch

[patch] OpenBSD patch

jasper-CVE-2008-3521.diff (text/plain), 1.33 KB, created by Tomas Hoger on 2008-09-08 13:35:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomas Hoger

Created: 2008-09-08 13:35:29 UTC

Size: 1.33 KB

patch

obsolete

>diff -pruN jasper-1.900.1.orig2/src/libjasper/base/jas_stream.c jasper-1.900.1/src/libjasper/base/jas_stream.c
>--- jasper-1.900.1.orig2/src/libjasper/base/jas_stream.c	2008-09-08 14:58:16.000000000 +0200
>+++ jasper-1.900.1/src/libjasper/base/jas_stream.c	2008-09-08 14:58:59.000000000 +0200
>@@ -361,28 +361,22 @@ jas_stream_t *jas_stream_tmpfile()
> 	}
> 	obj->fd = -1;
> 	obj->flags = 0;
>-	obj->pathname[0] = '\0';
> 	stream->obj_ = obj;
> 
> 	/* Choose a file name. */
>-	tmpnam(obj->pathname);
>+	snprintf(obj->pathname, L_tmpnam, "%stmp.XXXXXXXXXX", P_tmpdir);
> 
> 	/* Open the underlying file. */
>-	if ((obj->fd = open(obj->pathname, O_CREAT | O_EXCL | O_RDWR | O_TRUNC | O_BINARY,
>-	  JAS_STREAM_PERMS)) < 0) {
>+	if ((obj->fd = mkstemp(obj->pathname)) < 0) {
> 		jas_stream_destroy(stream);
> 		return 0;
> 	}
> 
> 	/* Unlink the file so that it will disappear if the program
> 	terminates abnormally. */
>-	/* Under UNIX, one can unlink an open file and continue to do I/O
>-	on it.  Not all operating systems support this functionality, however.
>-	For example, under Microsoft Windows the unlink operation will fail,
>-	since the file is open. */
> 	if (unlink(obj->pathname)) {
>-		/* We will try unlinking the file again after it is closed. */
>-		obj->flags |= JAS_STREAM_FILEOBJ_DELONCLOSE;
>+		jas_stream_destroy(stream);
>+		return 0;
> 	}
> 
> 	/* Use full buffering. */

Actions: View | Diff

Attachments on bug 461477: 316078