Attachment 316383 Details for Bug 461866 – net: Enable TSO if supported by at least one device

[patch] net: Enable TSO if supported by at least one device

p (text/plain), 1.35 KB, created by Herbert Xu on 2008-09-11 01:01:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Herbert Xu

Created: 2008-09-11 01:01:19 UTC

Size: 1.35 KB

patch

obsolete

>commit 543012edd71f9cd08c31e4c058525b4d331c823a
>Author: Herbert Xu <herbert@gondor.apana.org.au>
>Date:   Thu Sep 11 11:00:43 2008 +1000
>
>    net: Enable TSO if supported by at least one device
>    
>    As it stands users of netdev_compute_features (e.g., bridges/bonding)
>    will only enable TSO if all consituent devices support it.  This
>    is unnecessarily pessimistic since even on devices that do not
>    support hardware TSO and SG, emulated TSO still performs to a par
>    with TSO off.
>    
>    This patch enables TSO if at least on constituent device supports
>    it in hardware.
>    
>    The direct beneficiaries will be virtualisation that uses bridging
>    since this means that TSO will always be enabled for communication
>    from the host to the guests.
>    
>    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 489d044..7cb219c 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -3576,6 +3576,12 @@ int netdev_compute_features(unsigned long all, unsigned long one)
> 		one |= NETIF_F_GSO_SOFTWARE;
> 	one |= NETIF_F_GSO;
> 
>+	/*
>+	 * If even one device supports a GSO protocol with software fallback,
>+	 * enable it for all.
>+	 */
>+	all |= one & NETIF_F_GSO_SOFTWARE;
>+
>         /* If even one device supports robust GSO, enable it for all. */
> 	if (one & NETIF_F_GSO_ROBUST)
> 		all |= NETIF_F_GSO_ROBUST;

Actions: View | Diff

Attachments on bug 461866: 316378 | 316383