Attachment 317044 Details for Bug 462567 – workaround for the problem (fail to add fence device)

[patch] workaround for the problem (fail to add fence device)

system-config-cluster-10542-20080918.patch (text/plain), 2.42 KB, created by Binbin Wang on 2008-09-18 08:17:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Binbin Wang

Created: 2008-09-18 08:17:48 UTC

Size: 2.42 KB

patch

obsolete

>--- /a/usr/share/system-config-cluster/FenceHandler.py	2008-09-18 11:42:13.000000000 +0800
>+++ /b/usr/share/system-config-cluster/FenceHandler.py	2008-09-18 11:44:53.000000000 +0800
>@@ -799,10 +799,11 @@
>     fields["name"] = self.wti_fd_name.get_text()
>     fields["ipaddr"] = self.wti_fd_ip.get_text()
>     fields["passwd"] = self.wti_fd_passwd.get_text()
>-    if self.wti_ssh.get_active == True:
>-      fields["secure"] = "1"
>-    else:
>-      fields["secure"] = "0"
>+    if self.wti_ssh != None:	# wti_ssh here is NULL, avoid it call the get_active, which will cause 'NoneType' error.
>+        if self.wti_ssh.get_active == True:
>+      	    fields["secure"] = "1"
>+        else:
>+            fields["secure"] = "0"
> 
>     return fields
>  
>@@ -929,10 +930,11 @@
>     fields["hostname"] = self.ilo_fd_hostname.get_text()
>     fields["login"] = self.ilo_fd_login.get_text()
>     fields["passwd"] = self.ilo_fd_passwd.get_text()
>-    if self.ilo_ssh.get_active == True:
>-      fields["secure"] = "1"
>-    else:
>-      fields["secure"] = "0"
>+    if self.ilo_ssh != None:    #ilo_ssh here is NULL, avoid it calls the get_active, which will cause 'NoneType' error.
>+        if self.ilo_ssh.get_active == True:
>+          fields["secure"] = "1"
>+        else:
>+          fields["secure"] = "0"
> 
>     return fields
>  
>@@ -992,10 +994,11 @@
>     fields["ipaddr"] = self.drac_fd_ip.get_text()
>     fields["login"] = self.drac_fd_login.get_text()
>     fields["passwd"] = self.drac_fd_passwd.get_text()
>-    if self.drac_ssh.get_active == True:
>-      fields["secure"] = "1"
>-    else:
>-      fields["secure"] = "0"
>+    if self.drac_ssh != None:    # drac_ssh here is NULL, avoid it calls the get_active(), which will cause 'NoneType' error.
>+        if self.drac_ssh.get_active() == True:
>+          fields["secure"] = "1"
>+        else:
>+          fields["secure"] = "0"
> 
>     return fields
>  
>@@ -1185,10 +1188,11 @@
>     fields["ipaddr"] = self.bladecenter_fd_ip.get_text()
>     fields["login"] = self.bladecenter_fd_login.get_text()
>     fields["passwd"] = self.bladecenter_fd_passwd.get_text()
>-    if self.bc_ssh.get_active == True:
>-      fields["secure"] = "1"
>-    else:
>-      fields["secure"] = "0"
>+    if self.bc_ssh != None:    # bc_ssh here is NULL, avoid it calls the get_active(), which will cause 'NoneType' error.
>+        if self.bc_ssh.get_active() == True:
>+          fields["secure"] = "1"
>+        else:
>+          fields["secure"] = "0"
> 
>     return fields
>

Actions: View | Diff

Attachments on bug 462567: 317044 | 329013 | 329014 | 329388 | 329475