Attachment 317390 Details for Bug 454872 – add flush_disk to factor out common buffer cache flushing code

[patch] add flush_disk to factor out common buffer cache flushing code

5-added-flush_disk-to-factor-out-common-buffer-cache-flushing-code.patch (text/plain), 1.90 KB, created by Jeff Moyer on 2008-09-22 17:39:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Moyer

Created: 2008-09-22 17:39:08 UTC

Size: 1.90 KB

patch

obsolete

>Added flush_disk to factor out common buffer cache flushing code.
>
>We need to be able to flush the buffer cache for for more than
>just when a disk is changed, so we factor out common cache flush code
>in check_disk_change() to an internal flush_disk() routine.  This
>routine will then be used for both disk changes and disk resizes (in a
>later patch).
>
>Include the disk name in the text indicating that there are busy
>inodes on the device and increase the KERN severity of the message.
>
>diff -up linux-2.6.9/fs/block_dev.c.orig linux-2.6.9/fs/block_dev.c
>--- linux-2.6.9/fs/block_dev.c.orig	2008-09-22 11:26:04.649068219 -0400
>+++ linux-2.6.9/fs/block_dev.c	2008-09-22 13:18:26.334730795 -0400
>@@ -511,6 +511,33 @@ struct block_device *open_by_devnum(dev_
> 
> EXPORT_SYMBOL(open_by_devnum);
> 
>+
>+/**
>+ * flush_disk - invalidates all buffer-cache entries on a disk
>+ *
>+ * @bdev:      struct block device to be flushed
>+ *
>+ * Invalidates all buffer-cache entries on a disk. It should be called
>+ * when a disk has been changed -- either by a media change or online
>+ * resize.
>+ */
>+static void flush_disk(struct block_device *bdev)
>+{
>+	if (__invalidate_device(bdev)) {
>+		char name[BDEVNAME_SIZE] = "";
>+
>+		if (bdev->bd_disk)
>+			disk_name(bdev->bd_disk, 0, name);
>+		printk(KERN_WARNING "VFS: busy inodes on changed media %s\n",
>+		       name);
>+	}
>+
>+	if (!bdev->bd_disk)
>+		return;
>+	if (bdev->bd_disk->minors > 1)
>+		bdev->bd_invalidated = 1;
>+}
>+
> /**
>  * check_disk_size_change - checks for disk size change and adjusts
>  *                          bdev size.
>@@ -590,13 +617,9 @@ int check_disk_change(struct block_devic
> 	if (!bdops->media_changed(bdev->bd_disk))
> 		return 0;
> 
>-	if (__invalidate_device(bdev, 0))
>-		printk("VFS: busy inodes on changed media.\n");
>-
>+	flush_disk(bdev);
> 	if (bdops->revalidate_disk)
> 		bdops->revalidate_disk(bdev->bd_disk);
>-	if (bdev->bd_disk->minors > 1)
>-		bdev->bd_invalidated = 1;
> 	return 1;
> }
>

Actions: View | Diff

Attachments on bug 454872: 317386 | 317387 | 317388 | 317389 | 317390 | 317391