Attachment 317411 Details for Bug 427952 – Patch to allow needinfo? flag to be set during mass edit. (v1)

[patch] Patch to allow needinfo? flag to be set during mass edit. (v1)

needingo_mass_edit.patch (text/plain), 5.43 KB, created by David Lawrence on 2008-09-22 19:18:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-09-22 19:18:41 UTC

Size: 5.43 KB

patch

obsolete

>? bugzilla-3.2rh-20080922.1.tar.gz
>? bugzilla.spec
>? localconfig
>? patches
>? data/params
>Index: template/en/default/bug/edit.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/template/en/default/bug/edit.html.tmpl,v
>retrieving revision 1.49
>diff -u -r1.49 edit.html.tmpl
>--- template/en/default/bug/edit.html.tmpl	18 Sep 2008 16:54:57 -0000	1.49
>+++ template/en/default/bug/edit.html.tmpl	22 Sep 2008 18:25:20 -0000
>@@ -147,11 +147,11 @@
>   </script>
> 
> [%# REDHAT EXTENSION START 406451 %]
>+[%# Displays NEEDINFO tag in bug header %]
> [% FOREACH type = bug.flag_types %]
>   [% FOREACH flag = type.flags %]
>     [% IF type.name == 'needinfo' %]
>       [% needinfo_status = flag.status %]
>-      [% needinfo_from = flag.requestee.login %]
>     [% END %]
>   [% END %]
> [% END %]
>@@ -296,34 +296,8 @@
>           %]
>           <br>
> 
>-          [%# REDHAT EXTENSION START 406451 %]
>-          [% IF needinfo_status != "?" && bug.status.is_open %]
>-            <input type="checkbox" name="needinfo" 
>-                   value="1" [% IF needinfo_status == "?" %]checked="true"[% END %] 
>-                   id="needinfo">
>-            <label for="needinfo">Need additional information from</label>
>-            <select name="needinfo_role" id="needinfo_role" 
>-                    onchange="document.changeform.needinfo.checked=true;">
>-              <option value="">anyone</option>
>-              <option value="reporter">reporter</option>
>-              <option value="assigned_to">assignee</option>
>-              [% IF Param('useqacontact') && bug.qa_contact.login != "" %]
>-                <option value="qa_contact">qa contact</option>
>-              [% END %]
>-            </select>
>-            or other <input type="text" id="needinfo_from" 
>-                            name="needinfo_from" size="20" 
>-                            maxsize="40" value="[% needinfo_from FILTER html %]"
>-                            onchange="document.changeform.needinfo.checked=true;"/>
>-            <br>
>-          [% ELSIF needinfo_status == "?" %]
>-            [% IF needinfo_from == user.login || needinfo_from == "" %]
>-              Additional information was requested for this [% terms.bug %]. Adding comment will automatically clear needinfo request.
>-            [% ELSE %]
>-              <input type="checkbox" id="needinfo_override" name="needinfo_override" value="1"/>
>-              <label for="needinfo_override">I am providing the requested information for this [% terms.bug %].</label>
>-            [% END %]
>-          [% END %]
>+          [%# REDHAT EXTENSION END 406451 %]
>+          [% PROCESS bug/needinfo.html.tmpl %]
>           [%# REDHAT EXTENSION END 406451 %]
> 
>           <div id="knob-buttons">
>Index: template/en/default/bug/needinfo.html.tmpl
>===================================================================
>RCS file: template/en/default/bug/needinfo.html.tmpl
>diff -N template/en/default/bug/needinfo.html.tmpl
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ template/en/default/bug/needinfo.html.tmpl	22 Sep 2008 18:25:20 -0000
>@@ -0,0 +1,41 @@
>+[%# REDHAT EXTENSION START 406451 %]
>+
>+[% FOREACH type = bug.flag_types %]
>+  [% FOREACH flag = type.flags %]
>+    [% IF type.name == 'needinfo' %]
>+      [% needinfo_status = flag.status %]
>+      [% needinfo_from = flag.requestee.login %]
>+    [% END %]
>+  [% END %]
>+[% END %]
>+
>+[% IF (needinfo_status != "?" && bug.status.is_open) || massedit %]
>+  <input type="checkbox" name="needinfo" 
>+         value="1" [% IF needinfo_status == "?" %]checked="true"[% END %] 
>+         id="needinfo">
>+  <label for="needinfo">Need additional information from</label>
>+  <select name="needinfo_role" id="needinfo_role" 
>+          onchange="document.changeform.needinfo.checked=true;">
>+    <option value="">anyone</option>
>+    <option value="reporter">reporter</option>
>+    <option value="assigned_to">assignee</option>
>+    [% IF Param('useqacontact') && bug.qa_contact.login != "" %]
>+                <option value="qa_contact">qa contact</option>
>+    [% END %]
>+  </select>
>+  or other <input type="text" id="needinfo_from" 
>+                  name="needinfo_from" size="20" 
>+                  maxsize="40" value="[% needinfo_from FILTER html %]"
>+                  onchange="document.changeform.needinfo.checked=true;"/>
>+  <br>
>+[% ELSIF needinfo_status == "?" %] 
>+  [% IF needinfo_from == user.login || needinfo_from == "" %]
>+    Additional information was requested for this [% terms.bug %]. Adding comment will automatically clear needinfo request.
>+  [% ELSE %]
>+    <input type="checkbox" id="needinfo_override" name="needinfo_override" value="1"/>
>+    <label for="needinfo_override">I am providing the requested information for this [% terms.bug %].</label>
>+  [% END %]
>+[% END %]
>+
>+[%# REDHAT EXTENSION END 406451 %]
>+
>Index: template/en/default/list/edit-multiple.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/template/en/default/list/edit-multiple.html.tmpl,v
>retrieving revision 1.10
>diff -u -r1.10 edit-multiple.html.tmpl
>--- template/en/default/list/edit-multiple.html.tmpl	7 Aug 2008 17:11:58 -0000	1.10
>+++ template/en/default/list/edit-multiple.html.tmpl	22 Sep 2008 18:25:20 -0000
>@@ -303,7 +303,12 @@
>   minrows = 5
>   maxrows = 25
>   cols    = constants.COMMENT_COLS
>-%]<br>
>+%]
>+<br>
>+[%# REDHAT EXTENSION END 406451 %]
>+[% PROCESS bug/needinfo.html.tmpl massedit = 1 %]
>+[%# REDHAT EXTENSION END 406451 %]
>+<br>
> 
> [% IF groups.size > 0 %]
>

Flags:

nelhawar: review+

Actions: View | Diff

Attachments on bug 427952: 317411