Attachment 317459 Details for Bug 463416 – scsi-fix-regression-introduced-by-typo-in-failfast.patch

[patch] scsi-fix-regression-introduced-by-typo-in-failfast.patch

scsi-fix-regression-introduced-by-typo-in-failfast.patch (text/plain), 1.33 KB, created by Mark McLoughlin on 2008-09-23 10:03:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark McLoughlin

Created: 2008-09-23 10:03:21 UTC

Size: 1.33 KB

patch

obsolete

>From: Mark McLoughlin <markmc@redhat.com>
>Date: Tue, 23 Sep 2008 10:53:25 +0100
>Subject: [RHEL5.3 PATCH] scsi: Fix regression introduced by typo in failfast changes
>
>This is for BZ 463416.
>
>With 2.6.18.4-116, udev can be seen to hang on some machines
>when loading sr_mod.
>
>The regression was introduced by:
>
>  commit 325d5462da6613a1353fa8cbc4603e8f056e67b1
>  [scsi] modify failfast so it does not always fail fast
>
>Fix what appears to be an obvious typo - SCSI_MLQUEUE_HOST_BUSY
>etc. are always non-zero, we should be checking whether the
>reason code matches these.
>
>Signed-off-by: Mark McLoughlin <markmc@redhat.com>
>---
> drivers/scsi/scsi_lib.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
>index d7f3fb8..50d4a41 100644
>--- a/drivers/scsi/scsi_lib.c
>+++ b/drivers/scsi/scsi_lib.c
>@@ -169,8 +169,9 @@ int scsi_attempt_requeue_command(struct scsi_cmnd *cmd, int reason)
> 	 * want to bypass the failfast and retry checks like we do
> 	 * with the new ones.
> 	 */
>-	if (SCSI_MLQUEUE_HOST_BUSY || SCSI_MLQUEUE_DEVICE_BUSY ||
>-	    SCSI_MLQUEUE_EH_RETRY)
>+	if (reason == SCSI_MLQUEUE_HOST_BUSY ||
>+	    reason == SCSI_MLQUEUE_DEVICE_BUSY ||
>+	    reason == SCSI_MLQUEUE_EH_RETRY)
> 		goto cleanup;
> 
> 	if (!scsi_ign_failfast(reason) && scsi_disposition_retry(reason)) {
>-- 
>1.5.5.1
>

Actions: View | Diff

Attachments on bug 463416: 317454 | 317456 | 317458 | 317459