Attachment 385409 Details for Bug 556664 – Patch to fix buffer overflow for files with length = 100

[patch] Patch to fix buffer overflow for files with length = 100

star.patch (text/plain), 1.12 KB, created by Ondrej Vasik on 2010-01-19 14:26:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ondrej Vasik

Created: 2010-01-19 14:26:26 UTC

Size: 1.12 KB

patch

obsolete

>diff -urNp star-1.5-orig/star/longnames.c star-1.5/star/longnames.c
>--- star-1.5-orig/star/longnames.c	2006-10-31 18:06:25.000000000 +0100
>+++ star-1.5/star/longnames.c	2010-01-19 13:39:14.251922445 +0100
>@@ -140,7 +140,7 @@ name_to_tcb(info, ptb)
> 	 * We need a test without 'add' because we currently never add a slash
> 	 * at the end of a directiry name when in CPIO mode.
> 	 */
>-	if (namelen > props.pr_maxnamelen) {
>+	if (namelen >= props.pr_maxnamelen) {
> 		enametoolong(name, namelen, props.pr_maxnamelen);
> 		return (FALSE);
> 	}
>@@ -150,7 +150,7 @@ name_to_tcb(info, ptb)
> 	if (is_dir(info) && !no_dirslash && name[namelen-1] != '/')
> 		add++;
> 
>-	if ((namelen+add) <= props.pr_maxsname) {	/* Fits in shortname */
>+	if ((namelen+add) < props.pr_maxsname) {	/* Fits in shortname */
> 		if (add)
> 			strcatl(ptb->dbuf.t_name, name, "/", (char *)NULL);
> 		else
>@@ -158,7 +158,7 @@ name_to_tcb(info, ptb)
> 		return (TRUE);
> 	}
> 
>-	if (namelen+add > props.pr_maxnamelen) {	/* Now we know 'add' */
>+	if (namelen+add >= props.pr_maxnamelen) {	/* Now we know 'add' */
> 		enametoolong(name, namelen+add, props.pr_maxnamelen);
> 		return (FALSE);
> 	}

Actions: View | Diff

Attachments on bug 556664: 385387 | 385409 | 388531