Attachment 389013 Details for Bug 561855 – allow lustre.* extended attributes to be backed up and restored

[patch] allow lustre.* extended attributes to be backed up and restored

tar-1.19-xattr-lustre.patch (text/plain), 3.16 KB, created by Andreas Dilger on 2010-02-05 08:16:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Dilger

Created: 2010-02-05 08:16:08 UTC

Size: 3.16 KB

patch

obsolete

>Back up all extended attributes (exluding ACL/SELinux, which have their own
>options already), and only filter them at restore time.
>
>This follows the principle of least surprise, in case users have backed
>up data, deleted it, and then discover that the xattrs they wanted to
>backup were not on the whitelist.  If needed, the whitelist can be changed
>and tar re-run to restore the missing xattrs.
>
>Signed-off-by: Andreas Dilger <adilger@sun.com>
>Signed-off-by: Girish Shilamkar <girish.shilamkar@sun.com>
>
>Index: tar-1.22.sun1/src/xattrs.c
>===================================================================
>--- tar-1.22.sun1.orig/src/xattrs.c
>+++ tar-1.22.sun1/src/xattrs.c
>@@ -235,11 +235,9 @@ void xattrs_xattrs_get(struct tar_stat_i
>             {
>               size_t len = strlen (attr);
>               ssize_t aret = 0;
>-              
>-              if (strncmp (attr, "user.", strlen("user.")) &&
>-                  strncmp (attr, "trusted.", strlen("trusted.")))
>-                goto next_attr; /* only store normal xattrs */
>-              
>+
>+	       /* Archive all xattrs during creation, decide at extraction time
>+	        * which ones are of interest/use for the target filesystem. */
>               while (((fd == -1) ? 
>                       ((aret = getxattr (file_name, attr, val, asz)) == -1) :
>                       ((aret = fgetxattr (fd, attr, val, asz)) == -1)) &&
>@@ -256,7 +254,6 @@ void xattrs_xattrs_get(struct tar_stat_info *st, char const *file_name, int fd)
>               else if (errno != ENOATTR)
>                 call_arg_warn ((fd==-1) ? "lgetxattr" : "fgetxattr", file_name);
>               
>-             next_attr:
>               attr += len + 1;
>               xret -= len + 1;
>             }
>@@ -472,10 +470,10 @@ void xattrs_xattrs_set(struct tar_stat_i
>           keyword += strlen("SCHILY.xattr.");
> 
>           if (strncmp (keyword, "user.", strlen("user.")) &&
>+              strncmp (keyword, "lustre.", strlen("lustre.")) &&
>               strncmp (keyword, "trusted.", strlen("trusted.")))
>             continue; /* don't try and set anything but normal xattrs */
>-            
>-          /* should we ignore trusted.* EPERM errors when not root ? */
>+
>           xattrs__fd_set (st, file_name, typeflag, keyword,
>                           st->xattr_map[scan].xval_ptr,
>                           st->xattr_map[scan].xval_len);
>Index: tar-1.22.sun1/src/xheader.c
>===================================================================
>--- tar-1.22.sun1.orig/src/xheader.c
>+++ tar-1.22.sun1/src/xheader.c
>@@ -1677,9 +1677,10 @@ struct xhdr_tab const xhdr_tab[] = {
>   { "SCHILY.xattr.system.posix_acl_default",
>     xattr_acls_d_coder, xattr_acls_d_decoder, false, false },
> 
>-  /* xattr's, use the star format note we only save the user/trusted varients... */
>+  /* xattrs use the star format.  note we only save some variants... */
>   { "SCHILY.xattr.user",    xattr_coder, xattr_decoder, false, true },
>   { "SCHILY.xattr.trusted", xattr_coder, xattr_decoder, false, true },
>+  { "SCHILY.xattr.lustre",  xattr_coder, xattr_decoder, false, true },
> 
>   /* ignore everything else in the xattr namespaces... */
>   { "SCHILY.xattr",         dummy_coder, dummy_decoder, false, true },

Flags:

kdudka: review+

Actions: View | Diff

Attachments on bug 561855: 388800 | 388801 | 389010 | 389012 | 389013 | 394722 | 395254