Attachment 435138 Details for Bug 613824 – try calculation of size in tapset, not source

[patch] try calculation of size in tapset, not source

workaround.patch (text/plain), 1.85 KB, created by Mark Wielaard on 2010-07-28 22:08:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Wielaard

Created: 2010-07-28 22:08:36 UTC

Size: 1.85 KB

patch

obsolete

>diff -r dd4d9f50ac7c Makefile.am
>--- a/Makefile.am	Mon Jul 26 09:38:47 2010 +0100
>+++ b/Makefile.am	Thu Jul 29 00:00:45 2010 +0200
>@@ -331,7 +331,8 @@
> 
> if ENABLE_SYSTEMTAP
> ICEDTEA_PATCHES += patches/systemtap.patch \
>-	patches/systemtap-gcc-4.5.patch
>+	patches/systemtap-gcc-4.5.patch \
>+	patches/systemtap-alloc-size-workaround.patch
> endif
> 
> if ENABLE_NSS
>diff -r dd4d9f50ac7c patches/systemtap-alloc-size-workaround.patch
>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>+++ b/patches/systemtap-alloc-size-workaround.patch	Thu Jul 29 00:00:45 2010 +0200
>@@ -0,0 +1,17 @@
>+Generating a dwarf location expression for variable * "constant" as used
>+in this probe argument triggers unforseen complications. See
>+https://bugzilla.redhat.com/show_bug.cgi?id=613824
>+Workaround for now by passing the size without HeapWordSize adjustment.
>+See also the hotspot.object_alloc in tapset/hotspot.stp[.in].
>+
>+--- openjdk.orig/hotspot/src/share/vm/runtime/sharedRuntime.cpp	2010-05-18 20:00:22.130618755 +0200
>++++ openjdk/hotspot/src/share/vm/runtime/sharedRuntime.cpp	2010-07-28 22:53:23.662310007 +0200
>+@@ -711,7 +711,7 @@
>+   int size = o->size();
>+   symbolOop name = klass->name();
>+   HS_DTRACE_PROBE4(hotspot, object__alloc, get_java_tid(thread),
>+-                   name->bytes(), name->utf8_length(), size * HeapWordSize);
>++                   name->bytes(), name->utf8_length(), size);
>+   return 0;
>+ }
>+ 
>diff -r dd4d9f50ac7c tapset/hotspot.stp.in
>--- a/tapset/hotspot.stp.in	Mon Jul 26 09:38:47 2010 +0100
>+++ b/tapset/hotspot.stp.in	Thu Jul 29 00:00:45 2010 +0200
>@@ -120,7 +120,7 @@
>   name = "object_alloc";
>   thread_id = $arg1;
>   class = user_string_n($arg2, $arg3);
>-  size = $arg4;
>+  size = $arg4 * $HeapWordSize; // Note - systemtap-alloc-size-workaround.patch
>   probestr = sprintf("%s(thread_id=%d,class='%s',size=0x%x)",
>                      name, thread_id, class, size);
> }

Actions: View | Diff

Attachments on bug 613824: 435138 | 435220