Attachment 481914 Details for Bug 680226 – Patch to improve handling of active fwraid during devicetree populate

[patch] Patch to improve handling of active fwraid during devicetree populate

fwraid-live-680226.4.patch (text/plain), 4.42 KB, created by David Lehman on 2011-03-02 17:22:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lehman

Created: 2011-03-02 17:22:22 UTC

Size: 4.42 KB

patch

obsolete

>diff --git a/pyanaconda/storage/devices.py b/pyanaconda/storage/devices.py
>index d1e767f..41722c3 100644
>--- a/pyanaconda/storage/devices.py
>+++ b/pyanaconda/storage/devices.py
>@@ -2810,7 +2810,7 @@ class MDRaidArrayDevice(StorageDevice):
>         device.setup()
>         udev_settle()
> 
>-        if self.spares:
>+        if self.spares > 0:
>             # mdadm doesn't like it when you try to incrementally add spares
>             return
> 
>diff --git a/pyanaconda/storage/devicetree.py b/pyanaconda/storage/devicetree.py
>index a57e5e1..d281a79 100644
>--- a/pyanaconda/storage/devicetree.py
>+++ b/pyanaconda/storage/devicetree.py
>@@ -1311,36 +1311,61 @@ class DeviceTree(object):
>                 log.warning("invalid data for %s: %s" % (name, e))
>                 return
> 
>-            # try to name the array based on the preferred minor
>-            md_info = devicelibs.mdraid.mdexamine(device.path)
>-            md_path = md_info.get("device", "")
>-            md_name = devicePathToName(md_info.get("device", ""))
>-            if md_name:
>+            md_name = None
>+            minor = None
>+
>+            # check the list of devices udev knows about to see if the array
>+            # this device belongs to is already active
>+            for dev in self.topology.devices_iter():
>+                md_dir = "/sys" + udev_device_get_sysfs_path(dev) + "/md"
>+                if not os.path.exists(md_dir):
>+                    continue
>+
>                 try:
>-                    # md_name can be either md# or md/#
>-                    if md_name.startswith("md/"):
>-                        minor = int(md_name[3:])     # strip off leading "md/"
>-                        md_name = "md%d" % minor     # use a regular md# name
>-                    else:
>-                        minor = int(md_name[2:])     # strip off leading "md"
>-                except (IndexError, ValueError):
>-                    minor = None
>-                    md_name = None
>-                else:
>-                    array = self.getDeviceByName(md_name)
>-                    if array and array.uuid != md_uuid:
>-                        md_name = None
>+                    dev_uuid = udev_device_get_md_uuid(dev)
>+                    dev_level = udev_device_get_md_level(dev)
>+                except KeyError:
>+                    continue
>+
>+                if dev_uuid is None or dev_level is None:
>+                    continue
>+
>+                if dev_uuid == md_uuid and dev_level == md_level:
>+                    md_name = udev_device_get_name(dev)
>+                    minor = udev_device_get_minor(dev)
>+                    break
> 
>             if not md_name:
>-                # if we don't have a name yet, find the first unused minor
>-                minor = 0
>-                while True:
>-                    if self.getDeviceByName("md%d" % minor):
>-                        minor += 1
>+                # try to name the array based on the preferred minor
>+                md_info = devicelibs.mdraid.mdexamine(device.path)
>+                md_path = md_info.get("device", "")
>+                md_name = devicePathToName(md_info.get("device", ""))
>+                if md_name:
>+                    try:
>+                        # md_name can be either md# or md/#
>+                        if md_name.startswith("md/"):
>+                            minor = int(md_name[3:])     # strip off leading "md/"
>+                            md_name = "md%d" % minor     # use a regular md# name
>+                        else:
>+                            minor = int(md_name[2:])     # strip off leading "md"
>+                    except (IndexError, ValueError):
>+                        minor = None
>+                        md_name = None
>                     else:
>-                        break
>+                        array = self.getDeviceByName(md_name)
>+                        if array and array.uuid != md_uuid:
>+                            md_name = None
>+
>+                if not md_name:
>+                    # if we don't have a name yet, find the first unused minor
>+                    minor = 0
>+                    while True:
>+                        if self.getDeviceByName("md%d" % minor):
>+                            minor += 1
>+                        else:
>+                            break
> 
>-                md_name = "md%d" % minor
>+                    md_name = "md%d" % minor
> 
>             log.debug("using name %s for md array containing member %s"
>                         % (md_name, device.name))

Actions: View | Diff

Attachments on bug 680226: 480825 | 481472 | 481913 | 481914