Attachment 573083 Details for Bug 781243 – info test patch to parse tainted modules with multiple signs

[patch] info test patch to parse tainted modules with multiple signs

info.patch (text/plain), 1.74 KB, created by Greg Nichols on 2012-03-27 14:33:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Nichols

Created: 2012-03-27 14:33:12 UTC

Size: 1.74 KB

patch

obsolete

>Index: info.py
>===================================================================
>--- info.py	(revision 1236)
>+++ info.py	(working copy)
>@@ -78,7 +78,7 @@
>                     success = False
>                     
>                 if tainted & Constants.TAINT_TECHPREVIEW_MODULE:
>-                    modules = Command("cat /proc/modules").getStringList(regex = "^(?P<mod_name>\w+)[\s\S]+\(T\)", regexGroup = "mod_name")
>+                    modules = self.getTaintedModules("T")
>                     badModules = list()
>                     for module in modules:
>                         if not module in self.techPreviewModuleWhitelist:
>@@ -90,7 +90,7 @@
>                             print module
>                             
>                 if tainted & Constants.TAINT_UNSIGNED_MODULE:
>-                    modules = Command("cat /proc/modules").getStringList(regex = "^[\s\S]+\(U\)")
>+                    modules = self.getTaintedModules("U")
>                     print "Unsigned modules:"
>                     for module in modules:
>                         print module
>@@ -124,6 +124,19 @@
>         
>         return success
>     
>+    def getTaintedModules(self, sign):
>+        pattern = re.compile("^(?P<mod_name>\w+)[\s\S]+\((?P<signs>[A-Z]+)\)")
>+        procModules = open("/proc/modules")
>+        modules = list()
>+        for line in procModules.readlines():
>+            match = pattern.match(line)
>+            if match:
>+                if sign in match.group("signs"):
>+                    modules.append(match.group("mod_name"))
>+        procModules.close()
>+        return modules
>+                    
>+    
>     def checkKernelIsGA(self):
>         
>         if "Red Hat"not in self.redHatRelease.getProduct() or self.redHatRelease.getVersion() < 5:

Actions: View | Diff

Attachments on bug 781243: 573083