Description: properly render the empty search result

Filename:

MIME Type:

Creator: Tony Fu

Created: 2012-03-28 01:06:09 UTC

Size: 2.85 KB

patch

>Index: list.cgi >=================================================================== >RCS file: /cvs/qa/hwcert/list.cgi,v >retrieving revision 1.39 >diff -u -r1.39 list.cgi >--- list.cgi 22 Mar 2012 08:22:13 -0000 1.39 >+++ list.cgi 28 Mar 2012 00:58:54 -0000 >@@ -900,6 +900,15 @@ > # Define the variables and functions that will be passed to the UI template. > > $vars->{'total_count'} = scalar @bugs; >+ >+# check if the list only includes one empty bug >+my $empty_list = 0; >+if (scalar @bugs == 1) { >+ my $bug_hash = @bugs[0]; >+ $empty_list = 1 unless scalar %$bug_hash; >+} >+$vars->{'empty_buglist'} = $empty_list; >+ > my @temp; > if ($curroffset+49 <= $vars->{'total_count'}) { > @temp = @bugs[$curroffset..$curroffset+49]; >Index: template/en/default/list/list.html.tmpl >=================================================================== >RCS file: /cvs/qa/hwcert/template/en/default/list/list.html.tmpl,v >retrieving revision 1.11 >diff -u -r1.11 list.html.tmpl >--- template/en/default/list/list.html.tmpl 17 Apr 2009 01:23:50 -0000 1.11 >+++ template/en/default/list/list.html.tmpl 28 Mar 2012 00:58:54 -0000 >@@ -59,23 +59,27 @@ > <p> > <div id='hdr_list_nav'></div> > </p> >+[% IF empty_buglist %] >+ <p>No results were found that matched your query.</p> >+[% ELSE %] >+ [%############################################################################%] >+ [%# Cert Table #%] >+ [%############################################################################%] >+ >+ [% FLUSH %] >+ [% PROCESS list/table.html.tmpl %] >+ >+ <p> >+ <div id='list_nav'> >+ <h2 class="accentLightWide"><span> >+ [% total_count %] certifications found | >+ [% IF showallurl %] <a href="list.cgi?[% showallurl %]">Show All</a>[% ELSE %] Show All[% END %] | >+ [% IF prevoffseturl && showallurl %] <a href="list.cgi?[% prevoffseturl %]">Prev</a>[% ELSE %] Prev[% END %] | >+ [% IF nextoffseturl && showallurl %] <a href="list.cgi?[% nextoffseturl %]">Next</a>[% ELSE %] Next[% END %] >+ </span></h2> >+ </div> > >-[%############################################################################%] >-[%# Cert Table #%] >-[%############################################################################%] >- >-[% FLUSH %] >-[% PROCESS list/table.html.tmpl %] >- >-<p> >-<div id='list_nav'> >- <h2 class="accentLightWide"><span> >- [% total_count %] certifications found | >- [% IF showallurl %] <a href="list.cgi?[% showallurl %]">Show All</a>[% ELSE %] Show All[% END %] | >- [% IF prevoffseturl && showallurl %] <a href="list.cgi?[% prevoffseturl %]">Prev</a>[% ELSE %] Prev[% END %] | >- [% IF nextoffseturl && showallurl %] <a href="list.cgi?[% nextoffseturl %]">Next</a>[% ELSE %] Next[% END %] >- </span></h2> >-</div> >+[% END %] > > <script type="text/javascript"> > header_nav = document.getElementById("hdr_list_nav"); View Attachment As Raw

Flags:

tfu: review? (rlandry)
tfu: review? (wshen)
tfu: review? (pxue)