Attachment 573865 Details for Bug 798519 – the patch with more comments

[patch] the patch with more comments

patch.diff (text/plain), 2.49 KB, created by Wei Shen on 2012-03-30 02:36:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Wei Shen

Created: 2012-03-30 02:36:15 UTC

Size: 2.49 KB

patch

obsolete

>Index: list.cgi
>===================================================================
>RCS file: /cvs/qa/hwcert/list.cgi,v
>retrieving revision 1.37.2.2
>retrieving revision 1.37.2.2.2.1
>diff -u -r1.37.2.2 -r1.37.2.2.2.1
>--- list.cgi    24 Feb 2012 08:19:27 -0000      1.37.2.2
>+++ list.cgi    28 Mar 2012 04:52:56 -0000      1.37.2.2.2.1
>@@ -796,6 +796,15 @@
>            push (@{$bug->{'platforms'}}, FetchOneColumn2());
>            $found=1;
>         }             
>+        # we need to convert all i586 etc. to i386 here
>+        # It is because i386 is used by rpm results and
>+        # i686 is used by gz results, some certs have both rpm and gz results, then the
>+        # certs will show i386 and i686 together. However, i386 is enough, need not show
>+        # i686.
>+        my @maps = map {s/i\d86/i386/ ||1, $_} @{$bug->{'platforms'}};
>+        my %platforms = reverse @maps;
>+        @{$bug->{'platforms'}} = sort keys %platforms;
>+
>         # If we can't find any arches in the test runs, just pass the bug arch.
>         if (! $found) {
>            push (@{$bug->{'platforms'}}, $bug->{'rep_platform'});
>Index: Bug.pm
>===================================================================
>RCS file: /cvs/qa/hwcert/Bugzilla/Bug.pm,v
>retrieving revision 1.68.2.4
>retrieving revision 1.68.2.4.2.1
>diff -u -r1.68.2.4 -r1.68.2.4.2.1
>--- Bug.pm      21 Mar 2012 07:40:22 -0000      1.68.2.4
>+++ Bug.pm      28 Mar 2012 04:52:56 -0000      1.68.2.4.2.1
>@@ -724,6 +724,8 @@
> 
>     $self->{'platforms'} = [];
>     if (%platforms) {
>+        my @maps = map {s/i\d86/i386/ ||1, $_} sort keys %platforms;
>+        %platforms = reverse @maps;
>         @{$self->{'platforms'}} = sort keys %platforms;
>     } else {
>         push (@{$self->{'platforms'}}, $self->{'rep_platform'});
>@@ -834,16 +836,10 @@
>                          cert_id = ( SELECT id FROM cert_records
>                                      WHERE bug_id = $self->{dup_id} )
>                      ORDER BY rep_platform";
>-        $sth = $dbh->prepare($query);
>-        $sth->execute();
>-        while ( @row = $sth->fetchrow_array()){
>-            if ( exists $data{'platforms'} ) {
>-                $data{'platforms'} .= " " .shift @row;
>-            }else{
>-                $data{'platforms'} = shift @row;
>-            }
>-        }
>-
>+        my $p = $dbh->selectcol_arrayref($query);
>+        my @maps = map {s/i\d86/i386/ ||1, $_} sort @$p;
>+        my %platforms = reverse @maps;
>+        $data{'platforms'} = join(" ", sort keys %platforms);
>     }
> 
>     $self->{'dup_info'} = \%data;
>

Flags:

wshen: review? (rlandry)

Actions: View | Diff

Attachments on bug 798519: 573865