Attachment 574501 Details for Bug 808033 – [RHEL 6.3 qemu-kvm PATCH] Do not loose cpu-hotplug event when guest handles PRSC method

[patch] [RHEL 6.3 qemu-kvm PATCH] Do not loose cpu-hotplug event when guest handles PRSC method

0001-Do-not-loose-cpu-hotplug-event-when-guest-handles-PR.patch (text/plain), 2.04 KB, created by Igor Mammedov on 2012-04-02 13:16:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Igor Mammedov

Created: 2012-04-02 13:16:22 UTC

Size: 2.04 KB

patch

obsolete

>From dd38abc4e04e18f2ab5f4a0e016f875c1496e799 Mon Sep 17 00:00:00 2001
>From: Igor Mammedov <imammedo@redhat.com>
>Date: Mon, 2 Apr 2012 13:45:10 +0200
>Subject: [RHEL 6.3 qemu-kvm PATCH] Do not loose cpu-hotplug event when guest handles PRSC
> method
>
>BZ#808033
>Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=4245978
>
>After receiving cpu-hotplug gpe event, guest masks event in
>gpe.en register, executes PRSC AML method and then resets
>cpu-hotplug bit in gpe.sts. If another cpus are hot-plugged
>after PRSC has been executed and before cpu-hotplug bit is
>reset in gpe.sts, then guest will loose gpe event and it will
>not see all added cpus.
>
>tested localy:
>  guest receives second cpu-hotplug event if cpus were
>  added after guest've executed PRSC and before it reset
>  cpu-hotplug bit in gpe.sts.
>
>Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>---
> hw/acpi.c |    9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
>diff --git a/hw/acpi.c b/hw/acpi.c
>index 43d45d6..2e5b883 100644
>--- a/hw/acpi.c
>+++ b/hw/acpi.c
>@@ -81,6 +81,7 @@ typedef struct PIIX4PMState {
>     /* for pci hotplug */
>     struct gpe_regs gpe;
>     struct pci_status pci0_status;
>+    uint16_t pending_gpe_events;
>     uint32_t pci0_hotplug_enable;
> } PIIX4PMState;
> 
>@@ -778,6 +779,10 @@ static void gpe_writeb(void *opaque, uint32_t addr, uint32_t val)
>         case GPE_BASE:
>         case GPE_BASE + 1:
>             gpe_reset_val(&g->sts, addr, val);
>+            if (pm_state->pending_gpe_events != g->sts) {
>+                g->sts |= pm_state->pending_gpe_events;
>+                pm_state->pending_gpe_events = 0;
>+            }
>             break;
>         case GPE_BASE + 2:
>         case GPE_BASE + 3:
>@@ -956,6 +961,10 @@ void qemu_system_cpu_hot_add(int cpu, int state)
>     /* update number of cpus in cmos, to allow BIOS see it on reboot */
>     rtc_set_memory(rtc_state, 0x5f, acpi_online_cpu_count() - 1);
> 
>+    if (pm_state->gpe.en != 0xffff) {
>+        pm_state->pending_gpe_events |= PIIX4_CPU_HOTPLUG_STATUS;
>+    }
>+
>     pm_update_sci(pm_state);
> }
> #endif
>-- 
>1.7.7.6
>

Actions: View | Diff

Attachments on bug 808033: 574501 | 575088 | 575398