Attachment 574855 Details for Bug 717926 – New defects in NetworkManager

New defects in NetworkManager

NetworkManager.added (text/plain), 6.66 KB, created by Pavel Raiskup on 2012-04-03 12:57:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pavel Raiskup

Created: 2012-04-03 12:57:29 UTC

Size: 6.66 KB

patch

obsolete

>csdiff -z ../20120307/RHEL-6.3/NetworkManager-0.8.1-24.el6/run1/NetworkManager-0.8.1-24.el6.err ../20120323/RHEL-6.3/NetworkManager-0.8.1-27.el6/run1/NetworkManager-0.8.1-27.el6.err
>
>Error: BUFFER_SIZE_WARNING:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:1606: buffer_size_warning: Calling strncpy with a maximum size argument of 16 bytes on destination array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the destination string unterminated.
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:1607: buffer_size_warning: Calling strncpy with a maximum size argument of 16 bytes on destination array "ifr.ifr_ifru.ifru_slave" of size 16 bytes might leave the destination string unterminated.
>
>Error: BUFFER_SIZE_WARNING:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-manager.c:2764: buffer_size_warning: Calling strncpy with a maximum size argument of 16 bytes on destination array "iwr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the destination string unterminated.
>
>Error: CHECKED_RETURN:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:2009: example_checked: "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_INGRESS_MAP, i, &from, &to)" has its value checked in "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_INGRESS_MAP, i, &from, &to)".
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:2019: example_checked: "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_EGRESS_MAP, i, &from, &to)" has its value checked in "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_EGRESS_MAP, i, &from, &to)".
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:2117: example_checked: "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_INGRESS_MAP, i, &from, &to)" has its value checked in "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_INGRESS_MAP, i, &from, &to)".
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:2123: example_checked: "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_EGRESS_MAP, i, &from, &to)" has its value checked in "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_EGRESS_MAP, i, &from, &to)".
>/builddir/build/BUILD/NetworkManager-0.8.1/system-settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c:9919: example_checked: "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_INGRESS_MAP, 0U, &from, &to)" has its value checked in "nm_setting_vlan_get_priority(s_vlan, NM_VLAN_INGRESS_MAP, 0U, &from, &to)".
>/builddir/build/BUILD/NetworkManager-0.8.1/cli/src/settings.c:572: check_return: Calling function "nm_setting_vlan_get_priority" without checking return value (as is done elsewhere 9 out of 10 times).
>/builddir/build/BUILD/NetworkManager-0.8.1/cli/src/settings.c:572: unchecked_value: No check of the return value of "nm_setting_vlan_get_priority(s_vlan, map, i, &from, &to)".
>
>Error: CONSTANT_EXPRESSION_RESULT:
>/builddir/build/BUILD/NetworkManager-0.8.1/libnm-util/nm-setting-vlan.c:486: logical_vs_bitwise: priv->flags & 0U /* !((NM_VLAN_FLAG_REORDER_HEADERS | NM_VLAN_FLAG_GVRP) | NM_VLAN_FLAG_LOOSE_BINDING) */ is always 0 regardless of the values of its operands. This occurs as the logical operand of if. Did you intend to use '~' rather than '!'?
>
>Error: FORWARD_NULL:
>/builddir/build/BUILD/NetworkManager-0.8.1/system-settings/plugins/ifcfg-rh/reader.c:3692: var_compare_op: Comparing "p" to null implies that "p" might be null.
>/builddir/build/BUILD/NetworkManager-0.8.1/system-settings/plugins/ifcfg-rh/reader.c:3702: alias_transfer: Assigning null: "w" = "p".
>/builddir/build/BUILD/NetworkManager-0.8.1/system-settings/plugins/ifcfg-rh/reader.c:3703: var_deref_op: Dereferencing null variable "w".
>
>Error: NEGATIVE_RETURNS:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-manager.c:2763: negative_return_fn: Function "socket(2, 2, 0)" returns a negative number.
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-manager.c:2763: var_assign: Assigning: signed variable "fd" = "socket".
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-manager.c:2773: negative_returns: "fd" is passed to a parameter that cannot be negative.
>
>Error: NO_EFFECT:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-device-vlan.c:640: unsigned_compare: This less-than-zero comparison of an unsigned value is never true. "priv->vlan_id < 0U".
>
>Error: OVERRUN_STATIC:
>/builddir/build/BUILD/NetworkManager-0.8.1/cli/src/connections.c:217: ptr_assign: Pointer "nmc->allowed_fields" is assigned the address of a static array pointer "nmc_fields_settings_names" of size 760 bytes.
>/builddir/build/BUILD/NetworkManager-0.8.1/cli/src/connections.c:253: overrun-buffer-val: Overrunning static array "nmc->allowed_fields" of size 760 bytes by passing it as an argument to a function which indexes it at byte position 920.
>/builddir/build/BUILD/NetworkManager-0.8.1/cli/src/settings.c:751: index_const: Pointer "nmc->allowed_fields" directly indexed by constant "23".
>
>Error: STRING_OVERFLOW:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-netlink-compat.c:193: fixed_size_dest: You might overrun the 24 byte fixed-size string "if_request.device1" by copying "if_name" without checking the length.
>
>Error: STRING_OVERFLOW:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-netlink-compat.c:124: fixed_size_dest: You might overrun the 24 byte fixed-size string "if_request.device1" by copying "if_name" without checking the length.
>
>Error: STRING_OVERFLOW:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-netlink-compat.c:161: fixed_size_dest: You might overrun the 24 byte fixed-size string "if_request.device1" by copying "if_name" without checking the length.
>
>Error: STRING_OVERFLOW:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-netlink-compat.c:226: fixed_size_dest: You might overrun the 24 byte fixed-size string "if_request.device1" by copying "if_name" without checking the length.
>
>Error: STRING_OVERFLOW:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:1931: fixed_size_dest: You might overrun the 24 byte fixed-size string "if_request.device1" by copying "iface" without checking the length.
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:1931: parameter_as_source: Note: This defect has an elevated risk because the source argument is a parameter of the current function.
>
>Error: STRING_OVERFLOW:
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:1905: fixed_size_dest: You might overrun the 24 byte fixed-size string "if_request.device1" by copying "master" without checking the length.
>/builddir/build/BUILD/NetworkManager-0.8.1/src/nm-system.c:1905: parameter_as_source: Note: This defect has an elevated risk because the source argument is a parameter of the current function.
>
>Error: UNUSED_VALUE:
>/builddir/build/BUILD/NetworkManager-0.8.1/libnm-util/nm-setting-vlan.c:271: returned_pointer: Pointer "priv" returned by "g_type_instance_get_private((GTypeInstance *)setting, nm_setting_vlan_get_type())" is never used.

Actions: View

Attachments on bug 717926: 510652 | 574855