Attachment 576210 Details for Bug 810809 – hardwaretest.py patch to return 1 if any test in the run fails

[patch] hardwaretest.py patch to return 1 if any test in the run fails

hardwaretest.patch (text/plain), 1.30 KB, created by Greg Nichols on 2012-04-09 13:11:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Nichols

Created: 2012-04-09 13:11:35 UTC

Size: 1.30 KB

patch

obsolete

>Index: hardwaretest.py
>===================================================================
>--- hardwaretest.py	(revision 1275)
>+++ hardwaretest.py	(working copy)
>@@ -731,6 +731,7 @@
>         self.certification.save(self.environment.getResultsPath())
>         
>         # Start testin'!
>+        combinedResult = True # assume all tests pass
>         for test in tests:
>             if test.isDisabled():
>                 print "skipping %s - disabled" % test.getName()
>@@ -783,12 +784,15 @@
>                         raise exception
>                 
>                 run.setSummary(summary)  
>+                if summary != Constants.PASS:
>+                    combinedResult = False
>                 run.getResultsAttachments(self.environment, outputFilePath)
>                     
>             except OSError, e:
>                 print "Test error: %s" % e
>                 syslog.syslog("Test error: %s" % e)
>                 testerror = True
>+                combinedResult = False
>         
>             # Log the end of the test.
>             run.setEndTime(self.getCurrentUTCTime())
>@@ -812,7 +816,7 @@
>         syslog.closelog()
>         self.certification.save(self.environment.getResultsPath())
>         
>-        return True
>+        return combinedResult
>     
>     def logDevices(self, test, run):
>         success = True

Actions: View | Diff

Attachments on bug 810809: 576210