Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 576290 Details for
Bug 810847
Python problem with nested IFs
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Proposed patch to change list comprehensions/generator expressions to simply emit a single POP_TOP in the cleanup block (if there is one)
remove-redundant-POP_TOP-instructions.patch (text/plain), 872 bytes, created by
Dave Malcolm
on 2012-04-09 19:20:35 UTC
(
hide
)
Description:
Proposed patch to change list comprehensions/generator expressions to simply emit a single POP_TOP in the cleanup block (if there is one)
Filename:
MIME Type:
Creator:
Dave Malcolm
Created:
2012-04-09 19:20:35 UTC
Size:
872 bytes
patch
obsolete
>diff -r ecae43294a0e Python/compile.c >--- a/Python/compile.c Sun Mar 18 07:31:17 2012 +0100 >+++ b/Python/compile.c Mon Apr 09 14:47:26 2012 -0400 >@@ -2649,10 +2649,9 @@ > > compiler_use_next_block(c, skip); > } >- for (i = 0; i < n; i++) { >+ if (n > 0) { > ADDOP_I(c, JUMP_FORWARD, 1); >- if (i == 0) >- compiler_use_next_block(c, if_cleanup); >+ compiler_use_next_block(c, if_cleanup); > ADDOP(c, POP_TOP); > } > ADDOP_JABS(c, JUMP_ABSOLUTE, start); >@@ -2749,11 +2748,9 @@ > > compiler_use_next_block(c, skip); > } >- for (i = 0; i < n; i++) { >+ if (n > 0) { > ADDOP_I(c, JUMP_FORWARD, 1); >- if (i == 0) >- compiler_use_next_block(c, if_cleanup); >- >+ compiler_use_next_block(c, if_cleanup); > ADDOP(c, POP_TOP); > } > ADDOP_JABS(c, JUMP_ABSOLUTE, start);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=576290">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 810847
: 576290