Attachment 576972 Details for Bug 600636 – Replace access() calls with euidaccess()

[patch] Replace access() calls with euidaccess()

lockdev-1.0.3-euidaccess.patch (text/plain), 1.25 KB, created by Oron Peled on 2012-04-12 06:50:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Oron Peled

Created: 2012-04-12 06:50:25 UTC

Size: 1.25 KB

patch

obsolete

>diff -up ./src/lockdev.c.orig ./src/lockdev.c
>--- ./src/lockdev.c.orig	2012-04-12 09:28:20.132721352 +0300
>+++ ./src/lockdev.c	2012-04-12 09:28:16.963720896 +0300
>@@ -623,7 +623,10 @@ dev_lock (const char *devname)
> 	if ( stat( device, &statbuf) == -1 ) {
> 		close_n_return(-errno);
> 	}
>-	if ( access( device, W_OK ) == -1 ) {
>+	/* check that the caller has write permission to the device
>+	 * to prevent denial-of-service attack by unauthorized users
>+	 */
>+	if ( euidaccess( device, W_OK ) == -1 ) {
> 		close_n_return(-errno);
> 	}
> 
>@@ -783,7 +786,10 @@ dev_relock (const char  *devname,
> 	if ( stat( device, &statbuf) == -1 ) {
> 		close_n_return(-errno);
> 	}
>-	if ( access( device, W_OK ) == -1 ) {
>+	/* check that the caller has write permission to the device
>+	 * to prevent denial-of-service attack by unauthorized users
>+	 */
>+	if ( euidaccess( device, W_OK ) == -1 ) {
> 		close_n_return(-errno);
> 	}
> 
>@@ -871,7 +877,10 @@ dev_unlock (const char *devname,
> 	if ( stat( device, &statbuf) == -1 ) {
> 		close_n_return(-errno);
> 	}
>-	if ( access( device, W_OK ) == -1 ) {
>+	/* check that the caller has write permission to the device
>+	 * to prevent denial-of-service attack by unauthorized users
>+	 */
>+	if ( euidaccess( device, W_OK ) == -1 ) {
> 		close_n_return(-errno);
> 	}
>

Actions: View | Diff

Attachments on bug 600636: 421414 | 576972 | 938865