Attachment 577128 Details for Bug 811946 – reinstate mempool_free in cell_release_singleton

[patch] reinstate mempool_free in cell_release_singleton

dm-thin-reinstate-missing-mempool_free-in-cell_release_singleton.patch (text/plain), 983 bytes, created by Alasdair Kergon on 2012-04-12 16:19:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alasdair Kergon

Created: 2012-04-12 16:19:39 UTC

Size: 983 bytes

patch

obsolete

>From: Alasdair G Kergon <agk@redhat.com>
>
>Fix a memory leak inadvertently introduced during simplification of
>cell_release_singleton() in commit 6f94a4c45a6f744383f9f695dde019998db3df55
>("dm thin: fix stacked bi_next usage").
>
>A cell's hlist_del() must be accompanied by a mempool_free().
>
>Signed-off-by: Alasdair G Kergon <agk@redhat.com>
>---
> drivers/md/dm-thin.c |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>Index: linux/drivers/md/dm-thin.c
>===================================================================
>--- linux.orig/drivers/md/dm-thin.c
>+++ linux/drivers/md/dm-thin.c
>@@ -303,9 +303,11 @@ static void cell_release(struct cell *ce
>  */
> static void __cell_release_singleton(struct cell *cell, struct bio *bio)
> {
>-	hlist_del(&cell->list);
> 	BUG_ON(cell->holder != bio);
> 	BUG_ON(!bio_list_empty(&cell->bios));
>+
>+	hlist_del(&cell->list);
>+	mempool_free(cell, prison->cell_pool);
> }
> 
> static void cell_release_singleton(struct cell *cell, struct bio *bio)

Actions: View | Diff

Attachments on bug 811946: 577128 | 577160