Attachment 577135 Details for Bug 810928 – Fix some stored XSS (Cross-site Scripting) in 'paste_user' and 'paste_lang' parameters.

Fix some stored XSS (Cross-site Scripting) in 'paste_user' and 'paste_lang' parameters.

fix-sticky-notes-stored-xss.patch (text/plain), 1.91 KB, created by Othman Madjoudj on 2012-04-12 16:32:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Othman Madjoudj

Created: 2012-04-12 16:32:59 UTC

Size: 1.91 KB

patch

obsolete

>diff --git a/list.php b/list.php
>index 37313b9..88277f2 100755
>--- a/list.php
>+++ b/list.php
>@@ -109,7 +109,7 @@ foreach ($rows as $row)
>     $geshi->set_overall_style('word-wrap:break-word;');
> 
>     // Generate the data
>-    $user = empty($row['author']) ? $lang->get('anonymous') : $row['author'];
>+    $user = empty($row['author']) ? $lang->get('anonymous') : htmlentities($row['author']);
>     $timestamp = $row['timestamp'];
>     $time = date('d M Y, h:i:s e', $timestamp);
>     $info = $lang->get('posted_info');
>@@ -141,7 +141,7 @@ foreach ($rows as $row)
>         'paste_id'          => $row['id'],
>         'paste_url'         => $nav->get_paste($row['id'], null, $project, $rss),
>         'paste_data'        => $code_data,
>-        'paste_lang'        => $row['language'],
>+        'paste_lang'        => htmlentities($row['language']),
>         'paste_info'        => $info,
>         'paste_time'        => $time,
>         'paste_timestamp'   => $timestamp,
>diff --git a/show.php b/show.php
>index cb7ab56..f19af2b 100755
>--- a/show.php
>+++ b/show.php
>@@ -208,7 +208,7 @@ $geshi->set_line_style('background: #f7f7f7; text-shadow: 0px 1px #fff; padding:
> $geshi->set_overall_style('word-wrap:break-word;');
> 
> // Generate the data
>-$user = empty($row['author']) ? $lang->get('anonymous') : $row['author'];
>+$user = empty($row['author']) ? $lang->get('anonymous') : htmlentities($row['author']);
> $time = date('d M Y, h:i:s e', $row['timestamp']);
> $info = $lang->get('posted_info');
> 
>@@ -225,7 +225,7 @@ $skin->escape($code_data);
> $skin->assign(array(
>     'paste_id'          => $row['id'],
>     'paste_data'        => $code_data,
>-    'paste_lang'        => $row['language'],
>+    'paste_lang'        => htmlentities($row['language']),
>     'paste_info'        => $info,
>     'paste_user'        => $user,
>     'paste_timestamp'   => $row['timestamp'],
>@@ -252,4 +252,4 @@ else
>     $skin->output();
> }
> 
>-?>
>\ No newline at end of file
>+?>

Actions: View

Attachments on bug 810928: 577135 | 577191 | 577433