Attachment 577160 Details for Bug 811946 – dm thin: fix memory leak of singleton cell

[patch] dm thin: fix memory leak of singleton cell

0001-dm-bio-prison-fix-memory-leak-of-singleton-cell.patch (text/plain), 1.13 KB, created by Mike Snitzer on 2012-04-12 20:01:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mike Snitzer

Created: 2012-04-12 20:01:54 UTC

Size: 1.13 KB

patch

obsolete

>From 404078fc0a5863673e2f7a8c396fa8659348cac1 Mon Sep 17 00:00:00 2001
>From: Mike Snitzer <snitzer@redhat.com>
>Date: Thu, 12 Apr 2012 13:19:42 -0400
>Subject: [PATCH] dm thin: fix memory leak of singleton cell
>
>---
> drivers/md/dm-thin.c |    9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>Index: linux-2.6/drivers/md/dm-thin.c
>===================================================================
>--- linux-2.6.orig/drivers/md/dm-thin.c
>+++ linux-2.6/drivers/md/dm-thin.c
>@@ -279,8 +279,10 @@ static void __cell_release(struct cell *
> 
> 	hlist_del(&cell->list);
> 
>-	bio_list_add(inmates, cell->holder);
>-	bio_list_merge(inmates, &cell->bios);
>+	if (inmates) {
>+		bio_list_add(inmates, cell->holder);
>+		bio_list_merge(inmates, &cell->bios);
>+	}
> 
> 	mempool_free(cell, prison->cell_pool);
> }
>@@ -303,9 +305,10 @@ static void cell_release(struct cell *ce
>  */
> static void __cell_release_singleton(struct cell *cell, struct bio *bio)
> {
>-	hlist_del(&cell->list);
> 	BUG_ON(cell->holder != bio);
> 	BUG_ON(!bio_list_empty(&cell->bios));
>+
>+	__cell_release(cell, NULL);
> }
> 
> static void cell_release_singleton(struct cell *cell, struct bio *bio)

Actions: View | Diff

Attachments on bug 811946: 577128 | 577160