Attachment 577191 Details for Bug 810928 – Patch that fixes some SQL Injections issues.

Patch that fixes some SQL Injections issues.

fix-sticky-notes-sql-inj.patch (text/plain), 1.16 KB, created by Othman Madjoudj on 2012-04-13 00:00:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Othman Madjoudj

Created: 2012-04-13 00:00:42 UTC

Size: 1.16 KB

patch

obsolete

>diff --git a/list.php b/list.php
>index 88277f2..ded58fb 100755
>--- a/list.php
>+++ b/list.php
>@@ -58,6 +58,9 @@ else
>     $lim_start = ($page * 10) - 10;
> }
> 
>+// Escape the project
>+$db->escape($project);
>+
> // Get total number of posts
> $sql = "SELECT COUNT(id) AS total FROM {$db->prefix}main WHERE " .
>        (!empty($project) ? "project='{$project}' AND " : '') .
>@@ -68,8 +71,6 @@ $total = $row[0]['total'];
> // Get page numbers
> $pagination = $skin->pagination($total, $page);
> 
>-// Escape the project
>-$db->escape($project);
> 
> // Get the list
> $sql = "SELECT * FROM {$db->prefix}main WHERE " .
>diff --git a/show.php b/show.php
>index f19af2b..330ea97 100755
>--- a/show.php
>+++ b/show.php
>@@ -53,6 +53,8 @@ if ($paste_id == 0)
>     $core->redirect($core->path() . 'all/');
> }
> 
>+$db->escape($paste_id);
>+
> // Get the paste data
> $sql = "SELECT * FROM {$db->prefix}main WHERE id={$paste_id} LIMIT 1";
> $row = $db->query($sql, true);
>@@ -111,6 +113,8 @@ if ($row['private'] == "1")
> // Check if password cookie is there
> if (!empty($row['password']) && !empty($sid))
> {
>+    $db->escape($sid);
>+
>     // Clean up the session data every 30 seconds
>     if (time() % 30 == 0)
>     {

Actions: View

Attachments on bug 810928: 577135 | 577191 | 577433