Attachment 578665 Details for Bug 814294 – Proposed Patch

[patch] Proposed Patch

0004-libnuma-fix-numa_all_cpus_ptr-when-bound-to-cpu0.patch (text/plain), 992 bytes, created by Travis Gummels on 2012-04-19 14:34:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Travis Gummels

Created: 2012-04-19 14:34:30 UTC

Size: 992 bytes

patch

obsolete

>From 346e427204fba80e86d6ebd8965610b89dc5c7d6 Mon Sep 17 00:00:00 2001
>From: Mark A. Grondona <mgrondona@llnl.gov>
>Date: Tue, 27 Mar 2012 15:51:28 -0700
>Subject: [PATCH 4/4] libnuma: fix numa_all_cpus_ptr when bound to cpu0
>
>A bug in the test for invalid maxproccpu leads to resetting the
>numa_all_cpus_ptr mask when the cpu affinity mask of the current
>task only contains CPU0. This leads to numa_all_cpus_ptr having
>all CPUs instead of just one.
>
>Fix the test to be < 0 instead of <= 0 -- 0 is a valid CPU number.
>---
> libnuma.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/libnuma.c b/libnuma.c
>index ab1bbb6..b8c3e83 100755
>--- a/libnuma.c
>+++ b/libnuma.c
>@@ -489,7 +489,7 @@ set_thread_constraints(void)
> 	 * As such let's reduce maxproccpu to the number of actual
> 	 * available cpus - 1.
> 	 */
>-	if (maxproccpu <= 0) {
>+	if (maxproccpu < 0) {
> 		for (i = 0; i <= hicpu; i++)
> 			numa_bitmask_setbit(numa_all_cpus_ptr, i);
> 		maxproccpu = hicpu;
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 814294: 578663 | 578665