Attachment 578810 Details for Bug 772773 – Patch 1 of 2 to fix the problem

[patch] Patch 1 of 2 to fix the problem

bz772773-lvm_by_vg-not-stripping-tags-part1.patch (text/plain), 1.30 KB, created by Jonathan Earl Brassow on 2012-04-19 23:59:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Earl Brassow

Created: 2012-04-19 23:59:26 UTC

Size: 1.30 KB

patch

obsolete

>This first patch removes a redundant test.  If the 'strip_and_add_tag' function succeeds, the operating node will be the owner - that is certain.  If it fails, then the ownership is unknown, but we will try again anyway.
>
>The problem comes when we try 'strip_and_add_tag' and it fails.  We may clean up the volume group, but we don't have a chance to add the proper tag before 'vg_owner' is called - making this test not only redundant in the good case, but fatal to operation in the bad case.
>
>This patch only fixes this bug if the service is moving due to a node failure.  If the service is moving due to an administrative command, the next node will see a tag on the VG that belongs to a live node and refuse to activate it.
>Index: resource-agents/rgmanager/src/resources/lvm_by_vg.sh
>===================================================================
>--- resource-agents.orig/rgmanager/src/resources/lvm_by_vg.sh
>+++ resource-agents/rgmanager/src/resources/lvm_by_vg.sh
>@@ -264,11 +264,7 @@ function vg_start_single
> 			return $OCF_ERR_GENERIC
> 		fi
> 
>-		vg_owner
>-		if [ $? -eq 0 ]; then
>-			ocf_log err "Unable to claim ownership of $OCF_RESKEY_vg_name"
>-			return $OCF_ERR_GENERIC
>-		fi
>+		ocf_log notice "Cleanup of $OCF_RESKEY_vg_name successful"
> 
> 		if ! strip_and_add_tag ||
> 		   ! vgchange -ay $OCF_RESKEY_vg_name; then

Actions: View | Diff

Attachments on bug 772773: 551697 | 578810 | 578811