Attachment 579124 Details for Bug 796906 – Partial fix for this bug

[patch] Partial fix for this bug

bz796096-replace-with-partial.patch (text/plain), 979 bytes, created by Jonathan Earl Brassow on 2012-04-20 23:14:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Earl Brassow

Created: 2012-04-20 23:14:37 UTC

Size: 979 bytes

patch

obsolete

>Index: LVM2/lib/metadata/raid_manip.c
>===================================================================
>--- LVM2.orig/lib/metadata/raid_manip.c
>+++ LVM2/lib/metadata/raid_manip.c
>@@ -1632,10 +1632,28 @@ int lv_raid_replace(struct logical_volum
> 	 *
> 	 * - We need to change the LV names when we insert them.
> 	 */
>+try_again:
> 	if (!_alloc_image_components(lv, allocate_pvs, match_count,
> 				     &new_meta_lvs, &new_data_lvs)) {
> 		log_error("Failed to allocate replacement images for %s/%s",
> 			  lv->vg->name, lv->name);
>+
>+		/*
>+		 * If this is a repair, then try to
>+		 * do better than all-or-nothing
>+		 */
>+		if (match_count > 1) {
>+			log_error("Attempting replacement of %u devices"
>+				  " instead of %u", match_count - 1, match_count);
>+			match_count--;
>+
>+			/*
>+			 * Since we are replacing some but not all of the bad
>+			 * devices, we must set partial_activation
>+			 */
>+			lv->vg->cmd->partial_activation = 1;
>+			goto try_again;
>+		}
> 		return 0;
> 	}
>

Actions: View | Diff

Attachments on bug 796906: 579124 | 579127