Attachment 581138 Details for Bug 786149 – Patch vfs - fix LOOKUP_DIRECTORY not propagated to managed_dentry() (updated)

[patch] Patch vfs - fix LOOKUP_DIRECTORY not propagated to managed_dentry() (updated)

vfs-fix-LOOKUP_DIRECTORY-not-propagated-to-managed_dentry.patch (text/plain), 1.79 KB, created by Ian Kent on 2012-04-30 03:59:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Kent

Created: 2012-04-30 03:59:58 UTC

Size: 1.79 KB

patch

obsolete

>vfs - fix LOOKUP_DIRECTORY not propagated to managed_dentry()
>
>From: Ian Kent <ikent@redhat.com>
>
>Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=798809
>
>The vfs-automount infrastructure assumes that LOOKUP_DIRECTORY will
>be included in the nameidata flags if a trailing slash is given on
>the path being walked. But this flag is private to __link_path_walk()
>so it must be added when looking up the last component.
>
>Also if the path being walked must follow a symlink that ends with a
>"/" the nameidata flag LOOKUP_DIRECTORY can be set earlier than the
>last path component and lead to an incorrect ENOTDIR.  For the purpose
>of possible automounting this flag isn't needed for intermediate path
>components because the LOOKUP_CONTINUE flag will be set. So the check
>must be made in do_lookup() so the LOOKUP_DIRECTORY flag is set only
>for the required call to follow_managed().
>
>Signed-off-by: Ian Kent <ikent@redhat.com>
>---
>
> fs/namei.c |    9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
>
>diff --git a/fs/namei.c b/fs/namei.c
>index 9a9dc01..9cafc2b 100644
>--- a/fs/namei.c
>+++ b/fs/namei.c
>@@ -941,6 +941,7 @@ static int do_lookup(struct nameidata *nd, struct qstr *name,
> {
> 	struct vfsmount *mnt = nd->path.mnt;
> 	struct dentry *dentry = __d_lookup(nd->path.dentry, name);
>+	int flags = nd->flags;
> 	struct dentry *parent;
> 	struct inode *dir;
> 	int err;
>@@ -953,7 +954,13 @@ found:
> done:
> 	path->mnt = mnt;
> 	path->dentry = dentry;
>-	err = follow_managed(path, nd->flags);
>+	/*
>+	 * Make sure follow_automount() knows about the trailing
>+	 * "/" but only for the real last path component.
>+	 */
>+	if (!(nd->flags & LOOKUP_CONTINUE) && name->name[name->len] == '/')
>+		flags |= LOOKUP_DIRECTORY;
>+	err = follow_managed(path, flags);
> 	if (unlikely(err < 0))
> 		path_put_conditional(path, nd);
> 	return err;

Actions: View | Diff

Attachments on bug 786149: 567951 | 567961 | 567962 | 568665 | 568666 | 577804 | 580327 | 580329 | 581138