Attachment 581774 Details for Bug 818436 – commit 8c34a2dc70070cca8d97ad3c0f2dfbec1a0d82d8 from otp github tree

commit 8c34a2dc70070cca8d97ad3c0f2dfbec1a0d82d8 from otp github tree

otp-0009-erts_fix_memory_corruption_when_reading_topology_info.patch (text/plain), 1.53 KB, created by IBM Bug Proxy on 2012-05-03 05:40:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2012-05-03 05:40:32 UTC

Size: 1.53 KB

patch

obsolete

>commit 8c34a2dc70070cca8d97ad3c0f2dfbec1a0d82d8
>Author: Sverker Eriksson <sverker@erlang.org>
>Date:   Thu Mar 15 16:42:40 2012 +0100
>
>    erts: Fix memory corruption when reading topology info
>    
>    If the number of processors actually found while reading sysfs
>    is lower than the configured value, we realloc() the cpuinfo array
>    to the smaller size, but we then iterate it using the original
>    configured size, thus corrupting memory beyond the allocated
>    block.
>
>diff --git a/erts/lib_src/common/erl_misc_utils.c b/erts/lib_src/common/erl_misc_utils.c
>index 4806311..162c908 100644
>--- a/erts/lib_src/common/erl_misc_utils.c
>+++ b/erts/lib_src/common/erl_misc_utils.c
>@@ -727,7 +727,7 @@ adjust_processor_nodes(erts_cpu_info_t *cpuinfo, int no_nodes)
> 
> 	prev = NULL;
> 	this = &cpuinfo->topology[0];
>-	last = &cpuinfo->topology[cpuinfo->configured-1];
>+	last = &cpuinfo->topology[cpuinfo->topology_size-1];
> 	while (1) {
> 	    if (processor == this->processor) {
> 		if (node != this->node)
>@@ -939,7 +939,7 @@ read_topology(erts_cpu_info_t *cpuinfo)
> 
> 	if (res > 1) {
> 	    prev = this++;
>-	    last = &cpuinfo->topology[cpuinfo->configured-1];
>+	    last = &cpuinfo->topology[cpuinfo->topology_size-1];
> 
> 	    while (1) {
> 		this->thread = ((this->node == prev->node
>@@ -1094,7 +1094,7 @@ read_topology(erts_cpu_info_t *cpuinfo)
> 
> 	if (res > 1) {
> 	    prev = this++;
>-	    last = &cpuinfo->topology[cpuinfo->configured-1];
>+	    last = &cpuinfo->topology[cpuinfo->topology_size-1];
> 
> 	    while (1) {
> 		this->thread = ((this->node == prev->node

Actions: View

Attachments on bug 818436: 581774