Attachment 586673 Details for Bug 818318 – review.txt

review.txt

php-digitalsandwich-Phake-review.txt (text/plain), 6.45 KB, created by Remi Collet on 2012-05-24 16:47:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-05-24 16:47:09 UTC

Size: 6.45 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines. BSD
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>     Note: The package did not built BR could therefore not be checked or the
>     package failed to build because of missing BR
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>[x]: MUST Sources contain only permissible code or content.
>[!]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: defattr(....) present in %files section. This is OK if packaging
>     for EPEL5. Otherwise not needed
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[x]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[-]: MUST Large documentation files are in a -doc subpackage, if required.
>[-]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>[x]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Requires correct, justified where necessary.
>[!]: MUST Rpmlint output is silent.
>php-digitalsandwich-Phake.noarch: W: no-documentation
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>/home/extras/SPECS/review/818318/Phake-1.0.2.tgz :
>  MD5SUM this package     : 3c9194947bd5fed2e39cacf18c2c3d70
>  MD5SUM upstream package : 3c9194947bd5fed2e39cacf18c2c3d70
>
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[-]: MUST Useful -debuginfo package or justification otherwise.
>[!]: SHOULD Reviewer should test that the package builds in mock.
>[!]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>Provides:
>php-pear(pear.digitalsandwich.com/Phake) = 1.0.2
>php-digitalsandwich-Phake = 1.0.2-1.fc17
>Requires:
>/bin/sh  
>/usr/bin/pear  
>php-channel(pear.digitalsandwich.com)  
>php-common >= 5.2.3
>[-]: SHOULD Package functions as described.
>[x]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD Scriptlets must be sane, if used.
>- install/uninstall correctly register/unregister the pear extension
>[x]: SHOULD SourceX is a working URL.
>[-]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>[-]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>PCI report:
>$ phpci print --recursive --report extension Phake-1.0.2
>PHP COMPAT INFO EXTENSION SUMMARY
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0              88
>  Reflection                                              5.0.0               7
>  SPL                                                0.2  5.0.0              12
>  standard                                                4.0.0              82
>-------------------------------------------------------------------------------
>All extension are provided by php-commoin
>
>$ koji build --scratch dist-rawhide php-digitalsandwich-Phake-1.0.2-1.fc16.src.rpm
>Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4099082
>4099082 build (dist-rawhide, php-digitalsandwich-Phake-1.0.2-1.fc16.src.rpm) completed successfully
>
>
>Issues:
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
>[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
>[!]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: defattr(....) present in %files section. This is OK if packaging
>     for EPEL5. Otherwise not needed
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
>
>
>Generated by fedora-review 0.1.3
>External plugins:

Flags:

fedora: review?

Actions: View

Attachments on bug 818318: 586673