Attachment 587175 Details for Bug 817303 – review.txt

review.txt

php-symfony2-Yaml-review.txt (text/plain), 7.39 KB, created by Remi Collet on 2012-05-28 07:40:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-05-28 07:40:24 UTC

Size: 7.39 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines => MIT
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>     Note: The package did not built BR could therefore not be checked or the
>     package failed to build because of missing BR
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[x]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[-]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>[x]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint output is silent.
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>/home/extras/SPECS/review/817303/Yaml-2.0.14.tgz :
>  MD5SUM this package     : 559990383b66014627135346bd600555
>  MD5SUM upstream package : 559990383b66014627135346bd600555
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[-]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock. => f17 
>[-]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>Provides:
>php-pear(pear.symfony.com/Yaml) = 2.0.14
>php-symfony2-Yaml = 2.0.14-3.fc17
>Requires:
>/bin/sh  
>/usr/bin/pear  
>php-channel(pear.symfony.com)  
>php-common >= 5.3.2
>php-ctype  
>php-date  
>php-iconv  
>php-json  
>php-mbstring  
>php-pcre  
>php-pear(PEAR)  
>[-]: SHOULD Package functions as described.
>[x]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD Scriptlets must be sane, if used.
>=> (un)install correctly (un)register the extension
>[x]: SHOULD SourceX is a working URL.
>[-]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[!]: SHOULD Spec use %global instead of %define.
>     Note: %define
>
>$ phpci  print --recursive --report extension Yaml-2.0.14/Symfony
>-------------------------------------------------------------------------------
>PHP COMPAT INFO EXTENSION SUMMARY
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0              63
>  ctype                                                   4.0.4               2
>  date                                                    4.0.0               1
>  iconv                                                   4.0.5               1
>  json                                             1.2.1  5.2.0               1
>  mbstring                                                4.0.6               9
>  pcre                                                    4.0.0              34
>  standard                                                4.0.0             188
>-------------------------------------------------------------------------------
>=> all Requires are OK.
>
>$ phpci  print --recursive --report class Yaml-2.0.14/Symfony
>-------------------------------------------------------------------------------
>  CLASS                                 EXTENSION         VERSION         COUNT
>-------------------------------------------------------------------------------
>  DumpException                                           5.3.0               2
>  Dumper                                                  5.3.0               2
>  Escaper                                                 5.3.0               5
>  Inline                                                  5.3.0               8
>  ParseException                                          5.3.0              19
>  Parser                                                  5.3.0               6
>  Unescaper                                               5.3.0               2
>  Yaml                                                    5.3.0               1
>  \RuntimeException                                       5.3.0               2
>-------------------------------------------------------------------------------
>=> All classes provided by this package (RuntimeException by php-common, SPL extension)
>
>
>Issues:
>[!]: MUST Package has no %clean section with rm -rf %{buildroot}
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.
>As you have clean EL-5 stuff (Buildroot, %defattr) you should also remove the %clean section and the rm -rf %{buildroot} in %install
>
>
>Generated by fedora-review 0.1.3
>External plugins:

Actions: View

Attachments on bug 817303: 587175