Attachment 587284 Details for Bug 825870 – Patch for CVE-2012-2654

[patch] Patch for CVE-2012-2654

openstack-nova-CVE-2012-2654.patch (text/plain), 1.75 KB, created by Kurt Seifried on 2012-05-28 20:30:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kurt Seifried

Created: 2012-05-28 20:30:36 UTC

Size: 1.75 KB

patch

obsolete

>diff --git a/nova/api/ec2/cloud.py b/nova/api/ec2/cloud.py
>index 012afb9..342ac97 100644
>--- a/nova/api/ec2/cloud.py
>+++ b/nova/api/ec2/cloud.py
>@@ -608,7 +608,7 @@ class CloudController(object):
>                       to_port=to_port, msg="For ICMP, the"
>                                            " type:code must be valid")
> 
>-            values['protocol'] = ip_protocol
>+            values['protocol'] = ip_protocol.lower()
>             values['from_port'] = from_port
>             values['to_port'] = to_port
>         else:
>diff --git a/nova/api/openstack/compute/contrib/security_groups.py b/nova/api/openstack/compute/contrib/security_groups.py
>index 281cc8c..a9368c5 100644
>--- a/nova/api/openstack/compute/contrib/security_groups.py
>+++ b/nova/api/openstack/compute/contrib/security_groups.py
>@@ -497,7 +497,7 @@ class SecurityGroupRulesController(SecurityGroupControllerBase):
>                       to_port=to_port, msg="For ICMP, the"
>                                            " type:code must be valid")
> 
>-            values['protocol'] = ip_protocol
>+            values['protocol'] = ip_protocol.lower()
>             values['from_port'] = from_port
>             values['to_port'] = to_port
>         else:
>diff --git a/nova/virt/firewall.py b/nova/virt/firewall.py
>index af13a58..fe541d7 100644
>--- a/nova/virt/firewall.py
>+++ b/nova/virt/firewall.py
>@@ -300,8 +300,8 @@ class IptablesFirewallDriver(FirewallDriver):
>                 else:
>                     fw_rules = ipv6_rules
> 
>-                protocol = rule.protocol
>-                if version == 6 and rule.protocol == 'icmp':
>+                protocol = rule.protocol.lower()
>+                if version == 6 and protocol == 'icmp':
>                     protocol = 'icmpv6'
> 
>                 args = ['-j ACCEPT']
>

Actions: View | Diff

Attachments on bug 825870: 587284