Attachment 588554 Details for Bug 826507 – patch -- more debug logging for krb5 upcalls

[patch] patch -- more debug logging for krb5 upcalls

0001-cifs.upcall-more-debug-logging-for-krb5-upcalls.patch (text/plain), 1.43 KB, created by Jeff Layton on 2012-06-01 18:08:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2012-06-01 18:08:40 UTC

Size: 1.43 KB

patch

obsolete

>From 9bde4118a3d9e1dfb7b2e523c2af62c818b08c05 Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@samba.org>
>Date: Fri, 1 Jun 2012 14:01:29 -0400
>Subject: [PATCH] cifs.upcall: more debug logging for krb5 upcalls
>
>Signed-off-by: Jeff Layton <jlayton@samba.org>
>---
> cifs.upcall.c |   11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>diff --git a/cifs.upcall.c b/cifs.upcall.c
>index 4f9fe21..6d774d7 100644
>--- a/cifs.upcall.c
>+++ b/cifs.upcall.c
>@@ -994,10 +994,12 @@ retry_new_hostname:
> 		break;
> 	}
> 
>-	if (rc)
>+	if (rc) {
>+		syslog(LOG_DEBUG, "Unable to obtain service ticket");
> 		goto out;
>+	}
> 
>-	/* pack SecurityBLob and SessionKey into downcall packet */
>+	/* pack SecurityBlob and SessionKey into downcall packet */
> 	datalen =
> 	    sizeof(struct cifs_spnego_msg) + secblob.length + sess_key.length;
> 	keydata = (struct cifs_spnego_msg *)calloc(sizeof(char), datalen);
>@@ -1029,8 +1031,10 @@ out:
> 	 * make sure the kernel doesn't hang it off of a searchable keyring
> 	 * and interfere with the next attempt to instantiate the key.
> 	 */
>-	if (rc != 0 && key == 0)
>+	if (rc != 0 && key == 0) {
>+		syslog(LOG_DEBUG, "Negating key");
> 		keyctl_negate(key, 1, KEY_REQKEY_DEFL_DEFAULT);
>+	}
> 	data_blob_free(&secblob);
> 	data_blob_free(&sess_key);
> 	SAFE_FREE(ccname);
>@@ -1038,5 +1042,6 @@ out:
> 	SAFE_FREE(arg.ip);
> 	SAFE_FREE(arg.username);
> 	SAFE_FREE(keydata);
>+	syslog(LOG_DEBUG, "Exit status %d", rc);
> 	return rc;
> }
>-- 
>1.7.10.2
>

Actions: View | Diff

Attachments on bug 826507: 588354 | 588356 | 588554 | 589065 | 589066 | 590928 | 591188