Attachment 591288 Details for Bug 831366 – Patch curing the issue

[patch] Patch curing the issue

ncurses-5.9-20120204-fix-caching.patch (text/plain), 1.06 KB, created by Philippe Troin on 2012-06-12 21:20:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Troin

Created: 2012-06-12 21:20:19 UTC

Size: 1.06 KB

patch

obsolete

>--- ncurses-5.9.orig/ncurses/tinfo/db_iterator.c	2012-06-12 13:14:13.000000000 -0700
>+++ ncurses-5.9/ncurses/tinfo/db_iterator.c	2012-06-12 13:12:57.000000000 -0700
>@@ -96,6 +96,11 @@
>     bool result = FALSE;
>     char *value = getenv(name);
> 
>+    if (NULL != value) {
>+	value = strdup(value);
>+	// Memory allocation failure unhandled
>+    }
>+
>     if (which < dbdLAST) {
> 	if (my_vars[which].name == 0 || strcmp(my_vars[which].name, name)) {
> 	    FreeIfNeeded(my_vars[which].value);
>@@ -112,6 +117,7 @@
> 	    result = TRUE;
> 	}
>     }
>+    if (!result) free(value);
>     return result;
> }
> 
>@@ -238,6 +244,7 @@
> NCURSES_EXPORT(void)
> _nc_first_db(DBDIRS * state, int *offset)
> {
>+    bool cache_has_expired = FALSE;
>     *state = dbdTIC;
>     *offset = 0;
> 
>@@ -246,7 +253,8 @@
>     /* build a blob containing all of the strings we will use for a lookup
>      * table.
>      */
>-    if (my_blob == 0) {
>+    if (my_blob == 0 || (cache_has_expired = cache_expired())) {
>+	if (cache_has_expired) free_cache();
> 	size_t blobsize = 0;
> 	const char *values[dbdLAST];
> 	struct stat *my_stat;

Actions: View | Diff

Attachments on bug 831366: 591287 | 591288