Attachment 591802 Details for Bug 831918 – 0001-misc.decompress-compare-mtime-without-sub-second-pre.patch

[patch] 0001-misc.decompress-compare-mtime-without-sub-second-pre.patch

0001-misc.decompress-compare-mtime-without-sub-second-pre.patch (text/plain), 1.16 KB, created by Scott Tsai on 2012-06-14 10:39:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Scott Tsai

Created: 2012-06-14 10:39:31 UTC

Size: 1.16 KB

patch

obsolete

>From 965a984cc486a57e66e4ab392abb16ce5a435e0f Mon Sep 17 00:00:00 2001
>From: Scott Tsai <scottt.tw@gmail.com>
>Date: Thu, 14 Jun 2012 18:34:00 +0800
>Subject: [PATCH] misc.decompress(): compare mtime without sub second
> precision
>
>On Linux filesystems with nano second timestamps,
>Python's os.stat() and os.utime() don't guarantee timpestamps
>would compare equal when read back (http://bugs.python.org/issue14127).
>
>This patch reduces timestamp precision to seconds before comparing them.
>---
> yum/misc.py |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/yum/misc.py b/yum/misc.py
>index 59aff5d..968b5eb 100644
>--- a/yum/misc.py
>+++ b/yum/misc.py
>@@ -1135,7 +1135,9 @@ def decompress(filename, dest=None, fn_only=False, check_timestamps=False):
>         fi = stat_f(filename)
>         fo = stat_f(out)
>         if fi and fo:
>-            if fo.st_mtime == fi.st_mtime:
>+            # Eliminate sub second precision in mtime before comparision,
>+            # see http://bugs.python.org/issue14127
>+            if int(fo.st_mtime) == int(fi.st_mtime):
>                 return out
>             if fn_only:
>                 # out exists but not valid
>-- 
>1.7.10.2
>

Actions: View | Diff

Attachments on bug 831918: 591773 | 591802