Attachment 594182 Details for Bug 828824 – 0001-rt2x00usb-do-not-check-STATUS_PENDING-bit-on-rx.patch

0001-rt2x00usb-do-not-check-STATUS_PENDING-bit-on-rx.patch

0001-rt2x00usb-do-not-check-STATUS_PENDING-bit-on-rx.patch (text/plain), 1.61 KB, created by Stanislaw Gruszka on 2012-06-25 13:15:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stanislaw Gruszka

Created: 2012-06-25 13:15:06 UTC

Size: 1.61 KB

patch

obsolete

>From f6663740c0186b7007a052535c16155ace7a742b Mon Sep 17 00:00:00 2001
>From: Stanislaw Gruszka <sgruszka@redhat.com>
>Date: Mon, 25 Jun 2012 12:45:03 +0200
>Subject: [PATCH] rt2x00usb: do not check STATUS_PENDING bit on rx
>
>ENTRY_DATA_STATUS_PENDING indicate state of TX entry, when we wait for
>status for just sent frame. It has no sense to set/keep this bit for
>RX entries, and seems doing that introduce race condition that make
>possible RX path to stall.
>
>Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>---
> drivers/net/wireless/rt2x00/rt2x00usb.c |    6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless/rt2x00/rt2x00usb.c
>index d357d1e..26f5a27 100644
>--- a/drivers/net/wireless/rt2x00/rt2x00usb.c
>+++ b/drivers/net/wireless/rt2x00/rt2x00usb.c
>@@ -344,8 +344,7 @@ static void rt2x00usb_work_rxdone(struct work_struct *work)
> 	while (!rt2x00queue_empty(rt2x00dev->rx)) {
> 		entry = rt2x00queue_get_entry(rt2x00dev->rx, Q_INDEX_DONE);
> 
>-		if (test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
>-		    !test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
>+		if (test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
> 			break;
> 
> 		/*
>@@ -397,8 +396,7 @@ static bool rt2x00usb_kick_rx_entry(struct queue_entry *entry, void* data)
> 	struct queue_entry_priv_usb *entry_priv = entry->priv_data;
> 	int status;
> 
>-	if (test_and_set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
>-	    test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
>+	if (test_and_set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
> 		return false;
> 
> 	rt2x00lib_dmastart(entry);
>-- 
>1.7.1
>

Actions: View

Attachments on bug 828824: 589542 | 589545 | 589546 | 589547 | 589549 | 594182 | 595753