Attachment 594258 Details for Bug 823075 – php-symfony2-Security-review.txt

php-symfony2-Security-review.txt

php-symfony2-Security-review.txt (text/plain), 8.06 KB, created by Remi Collet on 2012-06-25 18:42:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-06-25 18:42:27 UTC

Size: 8.06 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[-]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[x]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>	MIT
>[x]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint output is silent.
>
>rpmlint php-symfony2-Security-2.0.15-2.fc18.src.rpm
>
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>rpmlint php-symfony2-Security-2.0.15-2.fc18.noarch.rpm
>
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>/home/extras/SPECS/review/823075/Security-2.0.15.tgz :
>  MD5SUM this package     : 4e66aac7ad61570e2113b6e2ddc4aeb2
>  MD5SUM upstream package : 4e66aac7ad61570e2113b6e2ddc4aeb2
>
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[-]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[-]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
># rpm -qp --provides /var/lib/mock/fc17x/php-symfony2-Security-2.0.15-2.fc17.remi.noarch.rpm 
>php-pear(pear.symfony.com/Security) = 2.0.15
>php-symfony2-Security = 2.0.15-2.fc17.remi
># rpm -qp --requires /var/lib/mock/fc17x/php-symfony2-Security-2.0.15-2.fc17.remi.noarch.rpm 
>/bin/sh  
>/usr/bin/pear  
>php-channel(pear.symfony.com)  
>php-common >= 5.3.2
>php-date  
>php-hash  
>php-json  
>php-openssl  
>php-pcre  
>php-pear(PEAR)  
>php-pear(pear.symfony.com/ClassLoader) = 2.0.15
>php-pear(pear.symfony.com/EventDispatcher) = 2.0.15
>php-pear(pear.symfony.com/Finder) = 2.0.15
>php-pear(pear.symfony.com/Form) = 2.0.15
>php-pear(pear.symfony.com/HttpFoundation) = 2.0.15
>php-pear(pear.symfony.com/HttpKernel) = 2.0.15
>php-pear(pear.symfony.com/Routing) = 2.0.15
>php-reflection  
>php-spl  
>
>[-]: SHOULD Package functions as described.
>[x]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD Scriptlets must be sane, if used.
>(un)install the package properly (un)register the extension
>[x]: SHOULD SourceX is a working URL.
>[-]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>     Note: %define
>
>Issues:
>Koji scratch build
>http://koji.fedoraproject.org/koji/taskinfo?taskID=4194686
>
>$ phpci print --report extension --recursive Security-2.0.15
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0             512
>  Reflection                                              5.0.0               2
>  SPL                                                0.2  5.0.0              13
>  date                                                    4.0.0               5
>  hash                                               1.0  5.1.2               5
>  json                                             1.2.1  5.2.0               3
>  openssl                                                 4.0.4               1
>  pcre                                                    4.0.0               1
>  standard                                                4.0.0             938
>-------------------------------------------------------------------------------
>
>Check the *sql file placement
>
>From grep -r "^use " Security-2.0.15 | sed -e 's/.*://' | sort -u | less
>
>use Doctrine\Common\Cache\Cache;
>use Doctrine\Common\NotifyPropertyChanged;
>use Doctrine\Common\PropertyChangedListener;
>use Doctrine\DBAL\Driver\Connection;
>use Doctrine\DBAL\Driver\Statement;
>use Doctrine\DBAL\Schema\Schema as BaseSchema;
>use Symfony\Component\ClassLoader\UniversalClassLoader;
>use Symfony\Component\EventDispatcher\Event;
>use Symfony\Component\EventDispatcher\EventDispatcherInterface;
>use Symfony\Component\Finder\Finder;
>use Symfony\Component\Form\Extension\Csrf\CsrfProvider\CsrfProviderInterface;
>use Symfony\Component\HttpFoundation\Cookie;
>use Symfony\Component\HttpFoundation\RedirectResponse;
>use Symfony\Component\HttpFoundation\Request;
>use Symfony\Component\HttpFoundation\RequestMatcherInterface;
>use Symfony\Component\HttpFoundation\Response;
>use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
>use Symfony\Component\HttpKernel\Event\GetResponseEvent;
>use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;
>use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
>use Symfony\Component\HttpKernel\HttpKernelInterface;
>use Symfony\Component\HttpKernel\KernelEvents;
>use Symfony\Component\HttpKernel\Log\LoggerInterface;
>use Symfony\Component\Routing\Exception\MethodNotAllowedException;
>use Symfony\Component\Routing\Exception\ResourceNotFoundException;
>use Symfony\Component\Routing\RouterInterface;
>
>So need doctrine/DoctrineDBAL and doctrine/DoctrineCommon
>
>Generated by fedora-review 0.1.3
>External plugins:

Actions: View

Attachments on bug 823075: 594258