Attachment 594412 Details for Bug 835432 – Outcome of fedora-review tool

Outcome of fedora-review tool

python-pycxx-review.txt (text/plain), 12.46 KB, created by Alec Leamas on 2012-06-26 09:38:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alec Leamas

Created: 2012-06-26 09:38:25 UTC

Size: 12.46 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== C/C++ ====
>[x]: MUST Header files in -devel subpackage, if present.
>[x]: MUST Package does not contain any libtool archives (.la)
>[ ]: MUST Package does not contain kernel modules.
>[ ]: MUST Package contains no static executables.
>[x]: MUST Rpath absent or only used for internal libs.
>
>
>==== Generic ====
>[x]: EXTRA Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: EXTRA Spec file according to URL is the same as in SRPM.
>[ ]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>[ ]: MUST Package contains no bundled libraries.
>[ ]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[ ]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
>[ ]: MUST Package contains desktop file if it is a GUI application.
>[ ]: MUST Development files must be in a -devel package
>[ ]: MUST Package requires other packages for directories it uses.
>[ ]: MUST Package uses nothing in %doc for runtime.
>[ ]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Fully versioned dependency in subpackages, if present.
>[ ]: MUST Package complies to the Packaging Guidelines
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[ ]: MUST Large documentation files are in a -doc subpackage, if required.
>[ ]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[ ]: MUST License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "UNKNOWN", "*No copyright* UNKNOWN", "BSD (3 clause)", "BSD" For detailed
>     output of licensecheck see file: /home/leamas/FedoraReview/src/835432
>     -python-pycxx/licensecheck.txt
>[ ]: MUST License file installed when any subpackage combination is installed.
>[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: MUST Package is named using only allowed ascii characters.
>[ ]: MUST Package is named according to the Package Naming Guidelines.
>[ ]: MUST Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[ ]: MUST Package must own all directories that it creates.
>[ ]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[ ]: MUST Package is not relocatable.
>[ ]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[ ]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[ ]: MUST Package contains systemd file(s) if in need.
>[x]: MUST File names are valid UTF-8.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[ ]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[ ]: SHOULD Package functions as described.
>[ ]: SHOULD Latest version is packaged.
>[ ]: SHOULD Package does not include license text files separate from
>     upstream.
>[ ]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
>     justified.
>[x]: SHOULD SourceX / PatchY prefixed with %{name}.
>[x]: SHOULD SourceX is a working URL.
>[ ]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[ ]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: SHOULD %check is present and all tests pass.
>[ ]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[!]: SHOULD Spec use %global instead of %define.
>     Note: %define python_sitearch %(%{__python} -c 'from distutils import
>     sysconfig; import sys; sys.stdout.write(sysconfig.get_python_lib(1))')
>     %define python_sitelib %(%{__python} -c 'from distutils.sysconfig import
>     get_python_lib; import sys; sys.stdout.write(get_python_lib())') %define
>     python_siteinc %(%{__python} -c 'from distutils import sysconfig; import
>     sys; sys.stdout.write(sysconfig.get_python_inc(1))') %define
>     python_datadir %{_datadir}/python%{python_version}
>
>Issues:
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
>
>Rpmlint
>-------
>Checking: python-pycxx-devel-6.2.4-0.fc15.noarch.rpm
>          python-pycxx-6.2.4-0.fc15.src.rpm
>python-pycxx-devel.noarch: E: description-line-too-long C The python-pycxx-devel package provides the header and source files.  There is no
>python-pycxx-devel.noarch: W: obsolete-not-provided python-cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/cxx_extensions.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Version.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Extensions.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/IndirectPythonInterface.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Exception.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Config.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionTypeBase.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/WrapPython.h
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/cxxsupport.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Extensions.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/Python2/cxx_extensions.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/cxxextensions.c
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/IndirectPythonInterface.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Objects.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/PythonType.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/IndirectPythonInterface.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/Python2/cxxsupport.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/CxxDebug.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionModule.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Exception.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Config.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/Python2/cxxextensions.c
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionType.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Objects.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionOldType.hxx
>python-pycxx.src: W: strange-permission python-pycxx.spec 0744L
>2 packages and 0 specfiles checked; 1 errors, 27 warnings.
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint python-pycxx-devel
>python-pycxx-devel.noarch: I: enchant-dictionary-not-found en_US
>python-pycxx-devel.noarch: E: description-line-too-long C The python-pycxx-devel package provides the header and source files.  There is no
>python-pycxx-devel.noarch: W: obsolete-not-provided python-cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/cxx_extensions.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Version.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Extensions.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/IndirectPythonInterface.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Exception.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Config.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionTypeBase.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/WrapPython.h
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/cxxsupport.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Extensions.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/Python2/cxx_extensions.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/cxxextensions.c
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/IndirectPythonInterface.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/Objects.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/PythonType.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/IndirectPythonInterface.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/Python2/cxxsupport.cxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/CxxDebug.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionModule.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Exception.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Config.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/share/python2.7/CXX/Python2/cxxextensions.c
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionType.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Objects.hxx
>python-pycxx-devel.noarch: W: spurious-executable-perm /usr/include/python2.7/CXX/Python2/ExtensionOldType.hxx
>1 packages and 0 specfiles checked; 1 errors, 26 warnings.
># echo 'rpmlint-done:'
>
>Requires
>--------
>python-pycxx-devel-6.2.4-0.fc15.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    python  
>    python(abi) = 2.7
>
>Provides
>--------
>python-pycxx-devel-6.2.4-0.fc15.noarch.rpm:
>    
>    python-pycxx-devel = 6.2.4-0.fc15
>
>MD5-sum check
>-------------
>/home/leamas/FedoraReview/src/835432-python-pycxx/upstream/pycxx-6.2.4.tar.gz :
>  MD5SUM this package     : e2500da3ab64cdba7ce5756945c30f91
>  MD5SUM upstream package : e2500da3ab64cdba7ce5756945c30f91
>
>
>Generated by fedora-review 0.2.0git
>External plugins:

Actions: View

Attachments on bug 835432: 594412 | 594636