Attachment 594709 Details for Bug 772848 – scan result with patch

scan result with patch

defects-in-patches.js (text/plain), 25.82 KB, created by zhe peng on 2012-06-27 07:57:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: zhe peng

Created: 2012-06-27 07:57:50 UTC

Size: 25.82 KB

patch

obsolete

>{
>    "scan":
>    {
>        "analyzer": "coverity",
>        "analyzer-args": "--wait-for-license",
>        "analyzer-version": "5.5.1 (build 20111007133237)\\n",
>        "compilation-unit-count": 310,
>        "compilation-unit-ratio": 100,
>        "config": "rhel-5.7-x86_64-cscan",
>        "finished": "2012-06-26 08:31:36",
>        "host": "dell-per610-03.lab.eng.brq.redhat.com",
>        "started": "2012-06-26 08:14:09",
>        "tool": "cov-mockbuild",
>        "tool-args": "-t rhel-5.7-x86_64-cscan /tmp/covscan_aDVz_2/libvirt-0.8.2-26.el5.src.rpm",
>        "tool-version": "cov-mockbuild-0.20120620_0d80d6d-1.el6.noarch"
>    },
>    "defects":
>    [
>        {
>            "checker": "CHECKED_RETURN",
>            "key_event_idx": 6,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/daemon/libvirtd.c",
>                    "line": 3069,
>                    "event": "example_checked",
>                    "message": "\"virInitialize()\" has its value checked in \"virInitialize() < 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/python/libvirt-override.c",
>                    "line": 3569,
>                    "event": "example_checked",
>                    "message": "\"virInitialize()\" has its value checked in \"virInitialize() < 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 826,
>                    "event": "example_checked",
>                    "message": "\"virInitialize()\" has its value checked in \"virInitialize() < 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 764,
>                    "event": "example_checked",
>                    "message": "\"virInitialize()\" has its value checked in \"virInitialize() < 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 888,
>                    "event": "example_checked",
>                    "message": "\"virInitialize()\" has its value checked in \"virInitialize() < 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/tests/shunloadhelper.c",
>                    "line": 46,
>                    "event": "check_return",
>                    "message": "Calling function \"virInitialize\" without checking return value (as is done elsewhere 16 out of 19 times)."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/tests/shunloadhelper.c",
>                    "line": 46,
>                    "event": "unchecked_value",
>                    "message": "No check of the return value of \"virInitialize()\"."
>                }
>            ]
>        },
>        {
>            "checker": "DEADCODE",
>            "key_event_idx": 3,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "dead_error_condition",
>                    "message": "On this path, the condition \"maplen < 0\" cannot be true."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "at_least",
>                    "message": "After this line, the value of \"maplen\" is at least 1."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "new_values",
>                    "message": "Noticing condition \"maplen <= 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "dead_error_line",
>                    "message": "Execution cannot reach this expression \"maxinfo < 0\" inside statement \"if (!cpumaps ? maplen != 0 ...\"."
>                }
>            ]
>        },
>        {
>            "checker": "DEADCODE",
>            "key_event_idx": 3,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "dead_error_condition",
>                    "message": "On this path, the condition \"maxinfo < 0\" cannot be true."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5228,
>                    "event": "at_least",
>                    "message": "After this line, the value of \"maxinfo\" is at least 1."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5228,
>                    "event": "new_values",
>                    "message": "Noticing condition \"maxinfo < 1\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "dead_error_line",
>                    "message": "Execution cannot reach this expression \"maxinfo < -2147483648 / maplen\" inside statement \"if (!cpumaps ? maplen != 0 ...\"."
>                }
>            ]
>        },
>        {
>            "checker": "DEADCODE",
>            "key_event_idx": 4,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "dead_error_condition",
>                    "message": "On this path, the condition \"maplen == 0\" cannot be true."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "at_least",
>                    "message": "After this line, the value of \"maplen\" is at least 1."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "new_values",
>                    "message": "Noticing condition \"maplen < 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "new_values",
>                    "message": "Noticing condition \"maplen <= 0\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/libvirt.c",
>                    "line": 5235,
>                    "event": "dead_error_line",
>                    "message": "Execution cannot reach this expression \"0\" inside statement \"if (!cpumaps ? maplen != 0 ...\"."
>                }
>            ]
>        },
>        {
>            "checker": "NULL_RETURNS",
>            "key_event_idx": 7,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/conf/network_conf.c",
>                    "line": 921,
>                    "event": "example_checked",
>                    "message": "\"strstr(def->bridge, \"%d\")\" has its value checked in \"strstr(def->bridge, \"%d\")\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_util.c",
>                    "line": 142,
>                    "event": "example_checked",
>                    "message": "\"strstr(queryParam->value, \"://\")\" has its value checked in \"(tmp = strstr(queryParam->value, \"://\")) != NULL\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/node_device/node_device_linux_sysfs.c",
>                    "line": 87,
>                    "event": "example_assign",
>                    "message": "Assigning: \"p\" = return value from \"strstr(buf, \"0x\")\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/node_device/node_device_linux_sysfs.c",
>                    "line": 88,
>                    "event": "example_checked",
>                    "message": "\"p\" has its value checked in \"p != NULL\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/qemu/qemu_conf.c",
>                    "line": 3559,
>                    "event": "example_checked",
>                    "message": "\"strstr(emulator, \"kvm\")\" has its value checked in \"strstr(emulator, \"kvm\")\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/qemu/qemu_conf.c",
>                    "line": 5415,
>                    "event": "example_assign",
>                    "message": "Assigning: \"tmp\" = return value from \"strstr(nics[i], \"vlan=\")\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/qemu/qemu_conf.c",
>                    "line": 5417,
>                    "event": "example_checked",
>                    "message": "\"tmp\" has its value checked in \"tmp\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/storage/storage_backend.c",
>                    "line": 596,
>                    "event": "returned_null",
>                    "message": "Function \"strstr\" returns null (checked 114 out of 117 times)."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/storage/storage_backend.c",
>                    "line": 596,
>                    "event": "var_assigned",
>                    "message": "Assigning: \"start\" = null return value from \"strstr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/storage/storage_backend.c",
>                    "line": 597,
>                    "event": "dereference",
>                    "message": "Dereferencing a pointer that might be null \"start\" when calling \"strstr\". (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)"
>                }
>            ]
>        },
>        {
>            "checker": "OVERRUN_STATIC",
>            "key_event_idx": 0,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/virtaudit.c",
>                    "line": 128,
>                    "event": "overrun-local",
>                    "message": "Overrunning static array \"record_types\", with 3 elements, at position 3 with index variable \"type\"."
>                }
>            ]
>        },
>        {
>            "checker": "RESOURCE_LEAK",
>            "key_event_idx": 5,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1425,
>                    "event": "alloc_arg",
>                    "message": "Calling allocation function \"esxVI_ObjectSpec_Alloc\" on \"objectSpec\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi_types.generated.c",
>                    "line": 1164,
>                    "event": "alloc_arg",
>                    "message": "\"esxVI_Alloc\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1147,
>                    "event": "alloc_arg",
>                    "message": "\"virAllocN\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"calloc\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "var_assign",
>                    "message": "Assigning: \"*((void **)ptrptr)\" = \"calloc(count, size)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1471,
>                    "event": "leaked_storage",
>                    "message": "Variable \"objectSpec\" going out of scope leaks the storage it points to."
>                }
>            ]
>        },
>        {
>            "checker": "RESOURCE_LEAK",
>            "key_event_idx": 5,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1436,
>                    "event": "alloc_arg",
>                    "message": "Calling allocation function \"esxVI_PropertySpec_Alloc\" on \"propertySpec\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi_types.generated.c",
>                    "line": 1899,
>                    "event": "alloc_arg",
>                    "message": "\"esxVI_Alloc\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1147,
>                    "event": "alloc_arg",
>                    "message": "\"virAllocN\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"calloc\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "var_assign",
>                    "message": "Assigning: \"*((void **)ptrptr)\" = \"calloc(count, size)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1471,
>                    "event": "leaked_storage",
>                    "message": "Variable \"propertySpec\" going out of scope leaks the storage it points to."
>                }
>            ]
>        },
>        {
>            "checker": "RESOURCE_LEAK",
>            "key_event_idx": 5,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 2845,
>                    "event": "alloc_arg",
>                    "message": "Calling allocation function \"esxVI_ObjectSpec_Alloc\" on \"objectSpec\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi_types.generated.c",
>                    "line": 1164,
>                    "event": "alloc_arg",
>                    "message": "\"esxVI_Alloc\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1147,
>                    "event": "alloc_arg",
>                    "message": "\"virAllocN\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"calloc\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "var_assign",
>                    "message": "Assigning: \"*((void **)ptrptr)\" = \"calloc(count, size)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 2979,
>                    "event": "leaked_storage",
>                    "message": "Variable \"objectSpec\" going out of scope leaks the storage it points to."
>                }
>            ]
>        },
>        {
>            "checker": "RESOURCE_LEAK",
>            "key_event_idx": 5,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 2852,
>                    "event": "alloc_arg",
>                    "message": "Calling allocation function \"esxVI_PropertySpec_Alloc\" on \"propertySpec\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi_types.generated.c",
>                    "line": 1899,
>                    "event": "alloc_arg",
>                    "message": "\"esxVI_Alloc\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1147,
>                    "event": "alloc_arg",
>                    "message": "\"virAllocN\" allocates memory that is stored into \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"calloc\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 128,
>                    "event": "var_assign",
>                    "message": "Assigning: \"*((void **)ptrptr)\" = \"calloc(count, size)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 2979,
>                    "event": "leaked_storage",
>                    "message": "Variable \"propertySpec\" going out of scope leaks the storage it points to."
>                }
>            ]
>        },
>        {
>            "checker": "RESOURCE_LEAK",
>            "key_event_idx": 14,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vmx.c",
>                    "line": 921,
>                    "event": "alloc_fn",
>                    "message": "Calling allocation function \"virConfReadMem\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 791,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"virConfParse\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 709,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"virConfCreate\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 188,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"virConfNew\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 166,
>                    "event": "alloc_arg",
>                    "message": "\"virAlloc\" allocates memory that is stored into \"ret\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 100,
>                    "event": "alloc_fn",
>                    "message": "Storage is returned from allocation function \"calloc\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 100,
>                    "event": "var_assign",
>                    "message": "Assigning: \"*((void **)ptrptr)\" = \"calloc(1UL, size)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 173,
>                    "event": "return_alloc",
>                    "message": "Returning allocated memory \"ret\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 188,
>                    "event": "var_assign",
>                    "message": "Assigning: \"ret\" = \"virConfNew()\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 193,
>                    "event": "return_alloc",
>                    "message": "Returning allocated memory \"ret\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 709,
>                    "event": "var_assign",
>                    "message": "Assigning: \"ctxt.conf\" = \"virConfCreate(filename, flags)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 720,
>                    "event": "return_alloc",
>                    "message": "Returning allocated memory \"ctxt.conf\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/conf.c",
>                    "line": 791,
>                    "event": "return_alloc_fn",
>                    "message": "Directly returning storage allocated by \"virConfParse\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vmx.c",
>                    "line": 921,
>                    "event": "var_assign",
>                    "message": "Assigning: \"conf\" =  storage returned from \"virConfReadMem(vmx, strlen(vmx), 1U)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vmx.c",
>                    "line": 929,
>                    "event": "leaked_storage",
>                    "message": "Variable \"conf\" going out of scope leaks the storage it points to."
>                }
>            ]
>        },
>        {
>            "checker": "REVERSE_INULL",
>            "key_event_idx": 2,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1425,
>                    "event": "deref_ptr_in_call",
>                    "message": "Dereferencing pointer \"objectSpec\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi_types.generated.c",
>                    "line": 1164,
>                    "event": "deref_parm",
>                    "message": "Directly dereferencing parameter \"*ptrptr\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_vi.c",
>                    "line": 1459,
>                    "event": "check_after_deref",
>                    "message": "Dereferencing \"objectSpec\" before a null check."
>                }
>            ]
>        },
>        {
>            "checker": "UNUSED_VALUE",
>            "key_event_idx": 0,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/esx/esx_storage_driver.c",
>                    "line": 563,
>                    "event": "returned_pointer",
>                    "message": "Pointer \"vmfsInfo\" returned by \"esxVI_VmfsDatastoreInfo_DynamicCast(info)\" is never used."
>                }
>            ]
>        },
>        {
>            "checker": "USE_AFTER_FREE",
>            "key_event_idx": 3,
>            "events":
>            [
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/qemu/qemu_driver.c",
>                    "line": 8310,
>                    "event": "freed_arg",
>                    "message": "\"usbFreeDevice\" frees \"usb\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/hostusb.c",
>                    "line": 315,
>                    "event": "freed_arg",
>                    "message": "\"virFree\" frees parameter \"dev\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/util/memory.c",
>                    "line": 283,
>                    "event": "freed_arg",
>                    "message": "\"free\" frees parameter \"*((void **)ptrptr)\"."
>                },
>                {
>                    "file_name": "/builddir/build/BUILD/libvirt-0.8.2/src/qemu/qemu_driver.c",
>                    "line": 8359,
>                    "event": "pass_freed_arg",
>                    "message": "Passing freed pointer \"usb\" as an argument to function \"usbDeviceListSteal\"."
>                }
>            ]
>        }
>    ]
>}

Actions: View

Attachments on bug 772848: 594707 | 594709 | 601641